Showing 1,652 of 1,668 total issues
Method IPFS.Ls
has 52 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (i *IPFS) Ls(ctx context.Context, r *t.AnnotatedResource, out chan<- *t.AnnotatedResource) error {
ctx, span := i.Tracer.Start(ctx, "protocol.ipfs.Ls")
defer span.End()
path := absolutePath(r)
Similar blocks of code found in 2 locations. Consider refactoring. Open
package types
// SourceType is an enum of possible sources for resources.
type SourceType uint8
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 127.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
don't use underscores in Go names; interface method parameter expect_status should be expectStatus Open
GetBody(ctx context.Context, url string, expect_status int) (io.ReadCloser, error)
- Exclude checks
don't use underscores in Go names; method parameter expect_status should be expectStatus Open
func (g *httpBodyGetterImpl) GetBody(ctx context.Context, url string, expect_status int) (io.ReadCloser, error) {
- Exclude checks
Your code does not pass gofmt in 1 place. Go fmt your code! Open
package types
- Exclude checks
Expected an indentation at 4 instead of at 2. Open
max_reconnect: 100 # Maximum number of reconnect attempts
- Exclude checks
Expected an indentation at 4 instead of at 2. Open
lastseen_prunelen: 32768 # Expire lastseen buffer when size exceeds this. SNIFFER_LASTSEEN_PRUNELEN in env.
- Exclude checks
Unexpected tabs found. Open
"Name": "1268 - Alternate Universe - alt.txt",
- Exclude checks
Unexpected tabs found. Open
{
- Exclude checks
Unexpected tabs found. Open
},
- Exclude checks
Unexpected tabs found. Open
{
- Exclude checks
Unexpected tabs found. Open
{
- Exclude checks
Expected an indentation at 4 instead of at 2. Open
direntry_timeout: 1m # Request timeout for Ls() calls.
- Exclude checks
Expected an indentation at 4 instead of at 2. Open
files:
- Exclude checks
Unexpected tabs found. Open
"links": [
- Exclude checks
TODO found Confirmed
// TODO: Queue provider here, not AnnotatedResource.
- Exclude checks
Unexpected tabs found. Open
{
- Exclude checks
Unexpected tabs found. Open
"Hash": "QmeDqRReGuvExWPspp9h5F2YJfsrDmrXwAJVuPkcrAuxjn",
- Exclude checks
Expected an indentation at 4 instead of at 2. Open
reconnect_time: 2s # Time to wait between reconnects
- Exclude checks
Expected an indentation at 4 instead of at 2. Open
message_ttl: 4h # The expiration time for messages in the queue.
- Exclude checks