Sign upLogin

ipfs/ipfs-cluster

View on GitHub
Star
allocator/balanced/balanced.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function partitionMetrics has a Cognitive Complexity of 22 (exceeds 15 allowed). Consider refactoring.
Open

func partitionMetrics(set api.MetricsSet, by []string) *partitionedMetric {
    rootMetric := by[0]
    pnedMetric := &partitionedMetric{
        metricName: rootMetric,
        partitions: partitionValues(set[rootMetric]),
Severity: Minor
Found in allocator/balanced/balanced.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method partitionedMetric.chooseNext has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
Open

func (pnedm *partitionedMetric) chooseNext() peer.ID {
    lenp := len(pnedm.partitions)
    if lenp == 0 {
        return ""
    }
Severity: Minor
Found in allocator/balanced/balanced.go - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Your code does not pass gofmt in 2 places. Go fmt your code!
Open

// Package balanced implements an allocator that can sort allocations
Severity: Minor
Found in allocator/balanced/balanced.go by gofmt

There are no issues that match your filters.

Category
Status