Sign upLogin

iranianpep/code-jetter

View on GitHub
Star
components/contact/mappers/ContactMessageMapper.php

Summary

Maintainability
A
1 hr
Test Coverage

Missing class import via use statement (line '34', column '18').
Open

            (new \CodeJetter\core\ErrorHandler())->logError($e);
Severity: Minor
Found in components/contact/mappers/ContactMessageMapper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method add uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $output->setSuccess(false);
        }
Severity: Minor
Found in components/contact/mappers/ContactMessageMapper.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$includingInputs'.
Open

    public function getDefinedInputs($action = null, array $includingInputs = [], array $excludingInputs = [])
Severity: Minor
Found in components/contact/mappers/ContactMessageMapper.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$action'.
Open

    public function getDefinedInputs($action = null, array $includingInputs = [], array $excludingInputs = [])
Severity: Minor
Found in components/contact/mappers/ContactMessageMapper.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$extraDefinedInputs'.
Open

    public function add(array $inputs, array $fieldsValues = [], $extraDefinedInputs = [])
Severity: Minor
Found in components/contact/mappers/ContactMessageMapper.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        try {
            $definedInputs = $this->getDefinedInputs('add');

            $validator = new Validator($definedInputs, $inputs);
            $validatorOutput = $validator->validate();
Severity: Major
Found in components/contact/mappers/ContactMessageMapper.php and 1 other location - About 1 hr to fix
components/user/mappers/MemberGroupMapper.php on lines 32..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status