Sign upLogin

iranianpep/code-jetter

View on GitHub
Star
components/user/controllers/AdminUserController.php

Summary

Maintainability
F
5 days
Test Coverage

File AdminUserController.php has 433 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace CodeJetter\components\user\controllers;

use CodeJetter\components\page\models\Page;
Severity: Minor
Found in components/user/controllers/AdminUserController.php - About 6 hrs to fix

    The class AdminUserController has 17 public methods. Consider refactoring AdminUserController to keep number of public methods under 10.
    Open

    class AdminUserController extends BaseController
{
    /**
     * Generate login form.
     *
    Severity: Minor
    Found in components/user/controllers/AdminUserController.php by phpmd

    TooManyPublicMethods

    Since: 0.1

    A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

    By default it ignores methods starting with 'get' or 'set'.

    Example

    Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

    Method listMembers has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function listMembers()
    {
        // for pagination - for simple router url path is enough, for regex ones base path is needed
        $pager = new Pager($this->getURLParameters(), $this->getBasePath(), $this->getRouteInfo()->getUrl());
    Severity: Major
    Found in components/user/controllers/AdminUserController.php - About 2 hrs to fix

      Method viewMember has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function viewMember()
    {
        $urlParameters = $this->getURLParameters();

        if (empty($urlParameters['id'])) {
      Severity: Major
      Found in components/user/controllers/AdminUserController.php - About 2 hrs to fix

        Method safeBatchDeleteMember has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function safeBatchDeleteMember()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
        Severity: Minor
        Found in components/user/controllers/AdminUserController.php - About 1 hr to fix

          Method batchDeleteMember has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function batchDeleteMember()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
          Severity: Minor
          Found in components/user/controllers/AdminUserController.php - About 1 hr to fix

            Method profileForm has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function profileForm()
    {
        $currentUser = (new AdminUser())->getLoggedIn();

        /**
            Severity: Minor
            Found in components/user/controllers/AdminUserController.php - About 1 hr to fix

              Function viewMember has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function viewMember()
    {
        $urlParameters = $this->getURLParameters();

        if (empty($urlParameters['id'])) {
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function batchDeleteMember has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function batchDeleteMember()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function safeBatchDeleteMember has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function safeBatchDeleteMember()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              The class AdminUserController has a coupling between objects value of 23. Consider to reduce the number of dependencies under 13.
              Open

              class AdminUserController extends BaseController
{
    /**
     * Generate login form.
     *
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php by phpmd

              CouplingBetweenObjects

              Since: 1.1.0

              A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

              Example

              class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

              Source https://phpmd.org/rules/design.html#couplingbetweenobjects

              Avoid using static access to class '\CodeJetter\core\Registry' in method 'viewMember'.
              Open

                      $language = Registry::getLanguageClass();
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\CodeJetter\core\Registry' in method 'listMembers'.
              Open

                      $language = Registry::getLanguageClass();
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\CodeJetter\core\Registry' in method 'profileForm'.
              Open

                      $language = Registry::getLanguageClass();
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function profileForm()
    {
        $currentUser = (new AdminUser())->getLoggedIn();

        /**
              Severity: Major
              Found in components/user/controllers/AdminUserController.php and 1 other location - About 6 hrs to fix
              components/user/controllers/MemberUserController.php on lines 617..657

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 216.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function resetPasswordForm()
    {
        $inputs = $this->getURLParameters();
        $output = (new AdminUser())->checkTokenIsValidByEmail($inputs['email'], $inputs['token']);
              Severity: Major
              Found in components/user/controllers/AdminUserController.php and 1 other location - About 4 hrs to fix
              components/user/controllers/MemberUserController.php on lines 343..368

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 177.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function safeDeleteMember()
    {
        $inputs = (new Request('POST'))->getInputs();

        if (!empty($inputs['id'])) {
              Severity: Major
              Found in components/user/controllers/AdminUserController.php and 1 other location - About 4 hrs to fix
              components/user/controllers/MemberGroupController.php on lines 150..179

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 175.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function loginForm()
    {
        $page = new Page($this->getRouteInfo()->getAccessRole());
        $page->setTitle('Login');
              Severity: Major
              Found in components/user/controllers/AdminUserController.php and 1 other location - About 2 hrs to fix
              components/user/controllers/MemberUserController.php on lines 101..129

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 140.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function forgotPasswordForm()
    {
        $page = new Page($this->getRouteInfo()->getAccessRole());
        $page->setTitle('Forgot your password');
              Severity: Major
              Found in components/user/controllers/AdminUserController.php and 1 other location - About 2 hrs to fix
              components/user/controllers/MemberUserController.php on lines 295..322

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      if ($output instanceof Output and (int) $output->getData() > 0) {
            // delete group xrefs if user is deleted
            // safe delete the group xrefs first, if there is any
            (new GroupMemberUserXrefMapper())->safeDelete([
                [
              Severity: Major
              Found in components/user/controllers/AdminUserController.php and 2 other locations - About 1 hr to fix
              components/user/controllers/MemberGroupController.php on lines 237..252
              components/user/controllers/MemberUserController.php on lines 594..611

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 116.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function resetPassword()
    {
        $inputs = (new Request('POST'))->getInputs(['email', 'resetPasswordToken', 'password', 'passwordConfirmation']);
        $output = (new AdminUser())->resetPassword(
            $inputs['email'],
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php and 1 other location - About 45 mins to fix
              components/user/controllers/MemberUserController.php on lines 373..384

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 35 and the first side effect is on line 29.
              Open

              <?php
              Severity: Minor
              Found in components/user/controllers/AdminUserController.php by phpcodesniffer

              There are no issues that match your filters.

              Category
              Status