Sign upLogin

iranianpep/code-jetter

View on GitHub
Star
components/user/controllers/MemberGroupController.php

Summary

Maintainability
F
3 days
Test Coverage

Method listGroups has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function listGroups()
    {
        // for pagination
        // for simple router url path is enough, for regex ones base path is needed
        $pager = new Pager($this->getURLParameters(), $this->getBasePath(), $this->getRouteInfo()->getUrl());
Severity: Major
Found in components/user/controllers/MemberGroupController.php - About 2 hrs to fix

    Method safeBatchDeleteGroup has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function safeBatchDeleteGroup()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
    Severity: Minor
    Found in components/user/controllers/MemberGroupController.php - About 1 hr to fix

      Method batchDeleteGroup has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function batchDeleteGroup()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
      Severity: Minor
      Found in components/user/controllers/MemberGroupController.php - About 1 hr to fix

        Function batchDeleteGroup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function batchDeleteGroup()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
        Severity: Minor
        Found in components/user/controllers/MemberGroupController.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function safeBatchDeleteGroup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function safeBatchDeleteGroup()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
        Severity: Minor
        Found in components/user/controllers/MemberGroupController.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The class MemberGroupController has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13.
        Open

        class MemberGroupController extends BaseController
{
    /**
     * Add a group.
     */
        Severity: Minor
        Found in components/user/controllers/MemberGroupController.php by phpmd

        CouplingBetweenObjects

        Since: 1.1.0

        A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

        Example

        class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

        Source https://phpmd.org/rules/design.html#couplingbetweenobjects

        Avoid using static access to class '\CodeJetter\core\Registry' in method 'listGroups'.
        Open

                $language = Registry::getLanguageClass();
        Severity: Minor
        Found in components/user/controllers/MemberGroupController.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function batchDeleteGroup()
    {
        $inputs = (new Request('POST'))->getInputs();

        /**
        Severity: Major
        Found in components/user/controllers/MemberGroupController.php and 1 other location - About 1 day to fix
        components/contact/controllers/ContactController.php on lines 293..351

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 383.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function safeDeleteGroup()
    {
        $inputs = (new Request('POST'))->getInputs();

        if (!empty($inputs['id'])) {
        Severity: Major
        Found in components/user/controllers/MemberGroupController.php and 1 other location - About 4 hrs to fix
        components/user/controllers/AdminUserController.php on lines 211..242

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 175.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function deleteGroup()
    {
        $inputs = (new Request('POST'))->getInputs();

        if (!empty($inputs['id'])) {
        Severity: Major
        Found in components/user/controllers/MemberGroupController.php and 1 other location - About 2 hrs to fix
        components/contact/controllers/ContactController.php on lines 262..286

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 135.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if ($output instanceof Output and (int) $output->getData() > 0) {
            (new GroupMemberUserXrefMapper())->safeDelete([
                [
                    'column'   => 'groupId',
                    'operator' => 'IN',
        Severity: Major
        Found in components/user/controllers/MemberGroupController.php and 2 other locations - About 1 hr to fix
        components/user/controllers/AdminUserController.php on lines 303..320
        components/user/controllers/MemberUserController.php on lines 594..611

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status