Sign upLogin

iranianpep/code-jetter

View on GitHub
Star
components/user/mappers/GroupUserXrefMapper.php

Summary

Maintainability
A
1 hr
Test Coverage

Method add has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function add(array $inputs, array $fieldsValues = [], $extraDefinedInputs = [])
    {
        /**
         * Start validating.
         */
Severity: Minor
Found in components/user/mappers/GroupUserXrefMapper.php - About 1 hr to fix

    Missing class import via use statement (line '50', column '18').
    Open

                (new \CodeJetter\core\ErrorHandler())->logError($e);
    Severity: Minor
    Found in components/user/mappers/GroupUserXrefMapper.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method add uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $output->setSuccess(false);
        }
    Severity: Minor
    Found in components/user/mappers/GroupUserXrefMapper.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid unused parameters such as '$extraDefinedInputs'.
    Open

        public function add(array $inputs, array $fieldsValues = [], $extraDefinedInputs = [])
    Severity: Minor
    Found in components/user/mappers/GroupUserXrefMapper.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid excessively long variable names like $fieldsValuesCollection. Keep variable name length under 20.
    Open

            $fieldsValuesCollection = [];
    Severity: Minor
    Found in components/user/mappers/GroupUserXrefMapper.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status