Sign upLogin

iranianpep/code-jetter

View on GitHub
Star
core/database/MySQLDatabase.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '31', column '31').
Open

            $connection = new \PDO("mysql:host={$host};dbname={$databaseName};charset=utf8", $user, $pass);
Severity: Minor
Found in core/database/MySQLDatabase.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '40', column '18').
Open

            (new \CodeJetter\core\ErrorHandler())->logError($e);
Severity: Minor
Found in core/database/MySQLDatabase.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '64', column '18').
Open

            (new \CodeJetter\core\ErrorHandler())->logError("Time zone: '{$timeZone}' is not valid.");
Severity: Minor
Found in core/database/MySQLDatabase.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method setTimeZone uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            (new \CodeJetter\core\ErrorHandler())->logError("Time zone: '{$timeZone}' is not valid.");
        }
Severity: Minor
Found in core/database/MySQLDatabase.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method connect() contains an exit expression.
Open

            exit;
Severity: Minor
Found in core/database/MySQLDatabase.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

There are no issues that match your filters.

Category
Status