Sign upLogin

iranianpep/code-jetter

View on GitHub
Star
core/io/Request.php

Summary

Maintainability
B
6 hrs
Test Coverage

getInputs accesses the super-global variable $_POST.
Open

    public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getServer accesses the super-global variable $_SERVER.
Open

    public function getServer($key)
    {
        switch ($key) {
            case 'SERVER_NAME':
                $info = filter_input(INPUT_SERVER, 'SERVER_NAME', FILTER_SANITIZE_STRING);
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getStartTime accesses the super-global variable $_SERVER.
Open

    public function getStartTime()
    {
        /*
         * REQUEST_TIME_FLOAT and REQUEST_TIME are not accessible through filter_input
         * This is a reported bug: https://bugs.php.net/bug.php?id=61497
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

checkOrigin accesses the super-global variable $_POST.
Open

    public function checkOrigin()
    {
        $output = new Output();

        switch ($this->getRequestMethod()) {
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getInputs accesses the super-global variable $_GET.
Open

    public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

checkOrigin accesses the super-global variable $_POST.
Open

    public function checkOrigin()
    {
        $output = new Output();

        switch ($this->getRequestMethod()) {
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getInputs accesses the super-global variable $_GET.
Open

    public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getInputs accesses the super-global variable $_POST.
Open

    public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getServer accesses the super-global variable $_SERVER.
Open

    public function getServer($key)
    {
        switch ($key) {
            case 'SERVER_NAME':
                $info = filter_input(INPUT_SERVER, 'SERVER_NAME', FILTER_SANITIZE_STRING);
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getInputs accesses the super-global variable $_POST.
Open

    public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getInputs accesses the super-global variable $_GET.
Open

    public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
Severity: Minor
Found in core/io/Request.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

The class Request has an overall complexity of 62 which is very high. The configured complexity threshold is 50.
Open

class Request
{
    private $requestMethod;
    private $inputs;
    private $queryString;
Severity: Minor
Found in core/io/Request.php by phpmd

Function getInputs has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
Severity: Minor
Found in core/io/Request.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getServer has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function getServer($key)
    {
        switch ($key) {
            case 'SERVER_NAME':
                $info = filter_input(INPUT_SERVER, 'SERVER_NAME', FILTER_SANITIZE_STRING);
Severity: Minor
Found in core/io/Request.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getServer has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getServer($key)
    {
        switch ($key) {
            case 'SERVER_NAME':
                $info = filter_input(INPUT_SERVER, 'SERVER_NAME', FILTER_SANITIZE_STRING);
Severity: Minor
Found in core/io/Request.php - About 1 hr to fix

    Method getInputs has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
    Severity: Minor
    Found in core/io/Request.php - About 1 hr to fix

      The method getInputs() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
      Open

          public function getInputs(array $inputKeys = [], $requestMethod = null)
    {
        if (isset($this->inputs)) {
            return $this->inputs;
        }
      Severity: Minor
      Found in core/io/Request.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method getServer() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
      Open

          public function getServer($key)
    {
        switch ($key) {
            case 'SERVER_NAME':
                $info = filter_input(INPUT_SERVER, 'SERVER_NAME', FILTER_SANITIZE_STRING);
      Severity: Minor
      Found in core/io/Request.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid using undefined variables such as '$exclude' which will lead to PHP notices.
      Open

                  if (!empty($exclude) && in_array($order[$orderByKey], $exclude)) {
      Severity: Minor
      Found in core/io/Request.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$exclude' which will lead to PHP notices.
      Open

                  if (!empty($exclude) && in_array($order[$orderByKey], $exclude)) {
      Severity: Minor
      Found in core/io/Request.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Missing class import via use statement (line '223', column '27').
      Open

                      throw new \Exception("Key '{$key}' is invalid server key info");
      Severity: Minor
      Found in core/io/Request.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method getInputs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    $inputs = $_POST;
                }
      Severity: Minor
      Found in core/io/Request.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\CodeJetter\core\Registry' in method 'getSortingFromQueryString'.
      Open

              $config = Registry::getConfigClass();
      Severity: Minor
      Found in core/io/Request.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method getInputs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    $inputs = $_GET;
                }
      Severity: Minor
      Found in core/io/Request.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Line exceeds 120 characters; contains 129 characters
      Open

              return $this->getServer('REMOTE_ADDR') ?: $this->getServer('HTTP_X_FORWARDED_FOR') ?: $this->getServer('HTTP_CLIENT_IP');
      Severity: Minor
      Found in core/io/Request.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status