iranianpep/code-jetter

View on GitHub
core/layout/blocks/Pager.php

Summary

Maintainability
A
2 hrs
Test Coverage

Pager has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class Pager extends BaseBlock
{
    private $total;
    private $totalPagesNo;
    private $currentPage;
Severity: Minor
Found in core/layout/blocks/Pager.php - About 2 hrs to fix

    The method getCounterStartNumber uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                return 1;
            }
    Severity: Minor
    Found in core/layout/blocks/Pager.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    There are no issues that match your filters.

    Category
    Status