Sign upLogin

iranianpep/code-jetter

View on GitHub
Star
core/security/Security.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '72', column '23').
Open

            throw new \Exception('Hash algorithm is not valid');
Severity: Minor
Found in core/security/Security.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '95', column '27').
Open

                throw new \Exception("Password algorithm constant: {$passwordAlgorithm} is not valid");
Severity: Minor
Found in core/security/Security.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method generateToken uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return uniqid(mt_rand(), true);
        }
Severity: Minor
Found in core/security/Security.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method hashPassword uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // if the algorithm is provided check it against whitelist
            $whitelist = [PASSWORD_DEFAULT, PASSWORD_BCRYPT];

            if (!in_array($passwordAlgorithm, $whitelist)) {
Severity: Minor
Found in core/security/Security.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\CodeJetter\core\App' in method 'checkAntiCSRF'.
Open

        $app = App::getInstance();
Severity: Minor
Found in core/security/Security.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method checkAntiCSRF uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return false;
        }
Severity: Minor
Found in core/security/Security.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 15 and the first side effect is on line 9.
Open

<?php
Severity: Minor
Found in core/security/Security.php by phpcodesniffer

There are no issues that match your filters.

Category
Status