Sign upLogin

iranianpep/code-jetter

View on GitHub
Star
core/utility/HTTPUtility.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method checkURL has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function checkURL($url, array $options = [])
    {
        if (empty($url)) {
            throw new \Exception('URL is empty');
        }
Severity: Major
Found in core/utility/HTTPUtility.php - About 3 hrs to fix

    Missing class import via use statement (line '24', column '23').
    Open

                throw new \Exception('URL is empty');
    Severity: Minor
    Found in core/utility/HTTPUtility.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method checkURL uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            return false;
        }
    Severity: Minor
    Found in core/utility/HTTPUtility.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid variables with short names like $ch. Configured minimum length is 3.
    Open

            $ch = curl_init($url);
    Severity: Minor
    Found in core/utility/HTTPUtility.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status