Sign upLogin

iranianpep/darksky

View on GitHub
Star

Showing 1 of 1 total issue

Remove error control operator '@' on line 26.
Open

    public function submit(string $requestUrl)
    {
        $content = @file_get_contents($requestUrl);

        if ($content === false) {
Severity: Minor
Found in src/Darksky/RequestMethod/Get.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Severity
Category
Status
Source
Language