irobayna/stupidedi

View on GitHub
lib/stupidedi/transaction_sets/builder.rb

Summary

Maintainability
C
1 day
Test Coverage

Method Segment has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

      def Segment(position, segment_def, name, requirement, repeat_count, *elements)
        unless elements.length == segment_def.element_uses.length
          raise Exceptions::InvalidSchemaError,
            "segment #{segment_def.id} has #{segment_def.element_uses.length}" +
            " elements but #{elements.length} arguments were given"
Severity: Minor
Found in lib/stupidedi/transaction_sets/builder.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Segment has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def Segment(position, segment_def, name, requirement, repeat_count, *elements)
        unless elements.length == segment_def.element_uses.length
          raise Exceptions::InvalidSchemaError,
            "segment #{segment_def.id} has #{segment_def.element_uses.length}" +
            " elements but #{elements.length} arguments were given"
Severity: Major
Found in lib/stupidedi/transaction_sets/builder.rb - About 2 hrs to fix

    Method mod_element has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

          def mod_element(element_use, descriptor, requirement, name, arguments)
            unless requirement.is_a?(Schema::ElementReq)
              raise Exceptions::InvalidSchemaError,
                "first argument to Element must be a Schema::ElementReq but got #{requirement.inspect} for #{descriptor}"
            end
    Severity: Minor
    Found in lib/stupidedi/transaction_sets/builder.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mod_element has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def mod_element(element_use, descriptor, requirement, name, arguments)
            unless requirement.is_a?(Schema::ElementReq)
              raise Exceptions::InvalidSchemaError,
                "first argument to Element must be a Schema::ElementReq but got #{requirement.inspect} for #{descriptor}"
            end
    Severity: Minor
    Found in lib/stupidedi/transaction_sets/builder.rb - About 1 hr to fix

      Method Segment has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def Segment(position, segment_def, name, requirement, repeat_count, *elements)
      Severity: Minor
      Found in lib/stupidedi/transaction_sets/builder.rb - About 45 mins to fix

        Method mod_element has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def mod_element(element_use, descriptor, requirement, name, arguments)
        Severity: Minor
        Found in lib/stupidedi/transaction_sets/builder.rb - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status