Sign upLogin

irobayna/stupidedi

View on GitHub
Star
lib/stupidedi/transaction_sets/validation/ambiguity.rb

Summary

Maintainability
D
2 days
Test Coverage

Method step has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

        def step(machine)
          machine.successors.head.constraints.each do |segment_id, table|
            case table
            when Stupidedi::Parser::ConstraintTable::Shallowest,
                 Stupidedi::Parser::ConstraintTable::Deepest
Severity: Minor
Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method step has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def step(machine)
          machine.successors.head.constraints.each do |segment_id, table|
            case table
            when Stupidedi::Parser::ConstraintTable::Shallowest,
                 Stupidedi::Parser::ConstraintTable::Deepest
Severity: Major
Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb - About 3 hrs to fix

    Method mksegments has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

            def mksegments(table)
          disjoint,   = table.basis(table.instructions, :insert)
          remaining   = Set.new(table.instructions)
          segment_id  = table.instructions.head.segment_use.id
          segments    = []
    Severity: Minor
    Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ambiguity.rb has 268 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Stupidedi
  using Refinements

  module TransactionSets
    module Validation
    Severity: Minor
    Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb - About 2 hrs to fix

      Method optional_elements has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

              def optional_elements(disjoint, instructions)
          designators = []

          disjoint.each do |(m, n), map|
            required = true
      Severity: Minor
      Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method mksegments has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def mksegments(table)
          disjoint,   = table.basis(table.instructions, :insert)
          remaining   = Set.new(table.instructions)
          segment_id  = table.instructions.head.segment_use.id
          segments    = []
      Severity: Minor
      Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb - About 1 hr to fix

        Method mkconfig has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def mkconfig(definition, functional_group_def, isa11, gs01, gs08, st01)
        Severity: Minor
        Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb - About 45 mins to fix

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def initialize(machine, reader, isa_elements, gs_elements, st_elements)
          Severity: Minor
          Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            case designators.length
                when 0
                when 1
                  raise Exceptions::InvalidSchemaError,
                    "proceeding from #{pp_machine(machine)}, the element
            Severity: Minor
            Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb and 1 other location - About 50 mins to fix
            lib/stupidedi/transaction_sets/validation/ambiguity.rb on lines 122..134

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            case designators.length
                when 0
                when 1
                  raise Exceptions::InvalidSchemaError,
                    "proceeding from #{pp_machine(machine)}, the element
            Severity: Minor
            Found in lib/stupidedi/transaction_sets/validation/ambiguity.rb and 1 other location - About 50 mins to fix
            lib/stupidedi/transaction_sets/validation/ambiguity.rb on lines 166..179

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status