Sign upLogin

ischenko/yii2-jsloader-requirejs

View on GitHub
Star

Showing 43 of 43 total issues

Avoid assigning values to variables in if clauses and the like (line '119', column '18').
Open

    public function toArray(): array
    {
        $config = $this->attributes;

        if (!empty($this->baseUrl)) {
Severity: Minor
Found in src/requirejs/Config.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\yii\di\Instance' in method 'init'.
Open

        $this->renderer = Instance::ensure($this->renderer, JsRendererInterface::class);
Severity: Minor
Found in src/RequireJs.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Possibly zero write references to public property \ischenko\yii2\jsloader\RequireJs->main
Open

    public $main;
Severity: Minor
Found in src/RequireJs.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::clearFallbackFiles()
Open

    public function clearFallbackFiles()
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero write references to public property \ischenko\yii2\jsloader\RequireJs->libraryPath
Open

    public $libraryPath = '@bower/requirejs/require.js';
Severity: Minor
Found in src/RequireJs.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::getCallback()
Open

    public function getCallback()
Severity: Minor
Found in src/requirejs/Config.php by phan

Doc-block of getConfig contains declared return type \ischenko\yii2\jsloader\requirejs\Config which is incompatible with the return type \ischenko\yii2\jsloader\ConfigInterface declared in the signature
Open

     * @return Config
Severity: Minor
Found in src/RequireJs.php by phan

Doc-block of setOptions contains declared return type static which is incompatible with the return type \ischenko\yii2\jsloader\ModuleInterface declared in the signature
Open

     * @return $this
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero references to protected method \ischenko\yii2\jsloader\RequireJs::doRender()
Open

    protected function doRender(array $jsExpressions)
Severity: Minor
Found in src/RequireJs.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::setInit()
Open

    public function setInit($init)
Severity: Minor
Found in src/requirejs/Module.php by phan

Assigning null to property but \ischenko\yii2\jsloader\requirejs\Module->exports is string
Open

            $this->exports = null;
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::setPaths()
Open

    public function setPaths(array $data)
Severity: Minor
Found in src/requirejs/Config.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::setShim()
Open

    public function setShim(array $data)
Severity: Minor
Found in src/requirejs/Config.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::setOptions()
Open

    public function setOptions(array $options): ModuleInterface
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\RequireJs::init()
Open

    public function init()
Severity: Minor
Found in src/RequireJs.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::setExports()
Open

    public function setExports($exports)
Severity: Minor
Found in src/requirejs/Module.php by phan

TODO found
Open

     * TODO: create setter and getter for map and config
Severity: Minor
Found in src/requirejs/Config.php by fixme

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::setCallback()
Open

    public function setCallback($value)
Severity: Minor
Found in src/requirejs/Config.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::addFallbackFiles()
Open

    public function addFallbackFiles(array $files)
Severity: Minor
Found in src/requirejs/Module.php by phan

Call with 1 arg(s) to \ischenko\yii2\jsloader\requirejs\Module::__construct() which only takes 0 arg(s) defined at /code/src/requirejs/Module.php:21
Open

            $module = new Module($module);
Severity: Info
Found in src/requirejs/Config.php by phan
Severity
Category
Status
Source
Language