Sign upLogin

ischenko/yii2-jsloader-requirejs

View on GitHub
Star
src/requirejs/Config.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function setShim has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function setShim(array $data)
    {
        foreach ($data as $moduleName => $properties) {
            if (empty($properties)) {
                continue;
Severity: Minor
Found in src/requirejs/Config.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function renderPaths has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function renderPaths(Module $module, &$config)
    {
        $options = $module->getOptions();
        $files = array_keys($module->getFiles());
Severity: Minor
Found in src/requirejs/Config.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setPaths has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function setPaths(array $data)
    {
        foreach ($data as $moduleName => $files) {
            if (empty($files)) {
                continue;
Severity: Minor
Found in src/requirejs/Config.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function toArray(): array
    {
        $config = $this->attributes;

        if (!empty($this->baseUrl)) {
Severity: Minor
Found in src/requirejs/Config.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid assigning values to variables in if clauses and the like (line '172', column '19').
Open

    public function setPaths(array $data)
    {
        foreach ($data as $moduleName => $files) {
            if (empty($files)) {
                continue;
Severity: Minor
Found in src/requirejs/Config.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '210', column '27').
Open

    public function setShim(array $data)
    {
        foreach ($data as $moduleName => $properties) {
            if (empty($properties)) {
                continue;
Severity: Minor
Found in src/requirejs/Config.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '124', column '18').
Open

    public function toArray(): array
    {
        $config = $this->attributes;

        if (!empty($this->baseUrl)) {
Severity: Minor
Found in src/requirejs/Config.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '248', column '14').
Open

    private function renderShim(Module $module)
    {
        $shimConfig = [];

        foreach ($module->getDependencies() as $dependency) {
Severity: Minor
Found in src/requirejs/Config.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '202', column '19').
Open

    public function setShim(array $data)
    {
        foreach ($data as $moduleName => $properties) {
            if (empty($properties)) {
                continue;
Severity: Minor
Found in src/requirejs/Config.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '252', column '14').
Open

    private function renderShim(Module $module)
    {
        $shimConfig = [];

        foreach ($module->getDependencies() as $dependency) {
Severity: Minor
Found in src/requirejs/Config.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '119', column '18').
Open

    public function toArray(): array
    {
        $config = $this->attributes;

        if (!empty($this->baseUrl)) {
Severity: Minor
Found in src/requirejs/Config.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::getCallback()
Open

    public function getCallback()
Severity: Minor
Found in src/requirejs/Config.php by phan

Possibly zero write references to private property \ischenko\yii2\jsloader\requirejs\Config::$validOptions
Open

    static private $validOptions = [
Severity: Minor
Found in src/requirejs/Config.php by phan

Call with 1 arg(s) to \ischenko\yii2\jsloader\requirejs\Module::__construct() which only takes 0 arg(s) defined at /code/src/requirejs/Module.php:21
Open

            $module = new Module($module);
Severity: Info
Found in src/requirejs/Config.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::toArray()
Open

    public function toArray(): array
Severity: Minor
Found in src/requirejs/Config.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::setShim()
Open

    public function setShim(array $data)
Severity: Minor
Found in src/requirejs/Config.php by phan

Doc-block of addModule contains declared return type \ischenko\yii2\jsloader\requirejs\Module which is incompatible with the return type \ischenko\yii2\jsloader\ModuleInterface declared in the signature
Open

     * @return Module
Severity: Minor
Found in src/requirejs/Config.php by phan

TODO found
Open

     * TODO: create setter and getter for map and config
Severity: Minor
Found in src/requirejs/Config.php by fixme

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::setPaths()
Open

    public function setPaths(array $data)
Severity: Minor
Found in src/requirejs/Config.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Config::setCallback()
Open

    public function setCallback($value)
Severity: Minor
Found in src/requirejs/Config.php by phan

There are no issues that match your filters.

Category
Status