Sign upLogin

ischenko/yii2-jsloader-requirejs

View on GitHub
Star
src/requirejs/Module.php

Summary

Maintainability
A
0 mins
Test Coverage

The method setExports uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if (!is_string($exports)) {
                throw new InvalidArgumentException('Exports must be a string');
            }
Severity: Minor
Found in src/requirejs/Module.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'setOptions'.
Open

        $rjsOptions = ArrayHelper::remove($options, 'requirejs', []);
Severity: Minor
Found in src/requirejs/Module.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Assigning null to property but \ischenko\yii2\jsloader\requirejs\Module->exports is string
Open

            $this->exports = null;
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::addFallbackFiles()
Open

    public function addFallbackFiles(array $files)
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::setExports()
Open

    public function setExports($exports)
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::setInit()
Open

    public function setInit($init)
Severity: Minor
Found in src/requirejs/Module.php by phan

Doc-block of setOptions contains declared return type static which is incompatible with the return type \ischenko\yii2\jsloader\ModuleInterface declared in the signature
Open

     * @return $this
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::clearFallbackFiles()
Open

    public function clearFallbackFiles()
Severity: Minor
Found in src/requirejs/Module.php by phan

Possibly zero references to public method \ischenko\yii2\jsloader\requirejs\Module::setOptions()
Open

    public function setOptions(array $options): ModuleInterface
Severity: Minor
Found in src/requirejs/Module.php by phan

There are no issues that match your filters.

Category
Status