Sign upLogin

ischenko/yii2-jsloader-systemjs

View on GitHub
Star

Showing 28 of 28 total issues

Method renderJsExpression has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function renderJsExpression(JsExpression $expression): string
    {
        $dependencies = $expression->getDependencies();

        while (($code = $expression->getExpression()) instanceof JsExpression) {
Severity: Minor
Found in src/systemjs/InlineRenderer.php - About 1 hr to fix

    Function prepareModules has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function prepareModules(): void
    {
        $extension = '.js';

        foreach ($this->getModules(new NotEmptyFiles(2)) as $module) {
    Severity: Minor
    Found in src/systemjs/Config.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid variables with short names like $js. Configured minimum length is 3.
    Open

        private function appendJsCode(string $js, JsExpression $expression, int $pos)
    Severity: Minor
    Found in src/SystemJs.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Function renderJsExpression has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function renderJsExpression(JsExpression $expression): string
    {
        $dependencies = $expression->getDependencies();

        while (($code = $expression->getExpression()) instanceof JsExpression) {
    Severity: Minor
    Found in src/systemjs/InlineRenderer.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method renderJsExpression uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $code = "function() {\n{$code}\n}";
            }
    Severity: Minor
    Found in src/systemjs/InlineRenderer.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\yii\helpers\Json' in method 'renderJsExpression'.
    Open

                $import = "System.import(" . Json::encode($alias) . ")";
    Severity: Minor
    Found in src/systemjs/InlineRenderer.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\yii\di\Instance' in method 'init'.
    Open

            $this->renderer = Instance::ensure($this->renderer, JsRendererInterface::class);
    Severity: Minor
    Found in src/SystemJs.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\ischenko\yii2\jsloader\helpers\FileHelper' in method 'registerImportMap'.
    Open

            $filePath = FileHelper::normalizePath($filePath);
    Severity: Minor
    Found in src/SystemJs.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '115', column '14').
    Open

        protected function registerImportMap(): void
    {
        if (($importMap = $this->getConfig()->toArray()) === []) {
            return;
        }
    Severity: Minor
    Found in src/SystemJs.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\yii\helpers\Json' in method 'registerImportMap'.
    Open

            $importMap = Json::encode($importMap, $options);
    Severity: Minor
    Found in src/SystemJs.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '37', column '18').
    Open

        public function toArray(): array
    {
        $this->prepareModules();

        $importMap = ['imports' => [], 'scopes' => []];
    Severity: Minor
    Found in src/systemjs/Config.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\ischenko\yii2\jsloader\helpers\FileHelper' in method 'prepareModules'.
    Open

                    $file = FileHelper::removeExtension($file, $extension);
    Severity: Minor
    Found in src/systemjs/Config.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method setExports uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            if (!is_string($exports)) {
                throw new InvalidArgumentException('Exports must be a string');
            }
    Severity: Minor
    Found in src/systemjs/Module.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\ischenko\yii2\jsloader\helpers\FileHelper' in method 'prepareModules'.
    Open

                        $newModule = FileHelper::normalizePath("{$alias}/{$newModule}", '/');
    Severity: Minor
    Found in src/systemjs/Config.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'setOptions'.
    Open

            $sjsOptions = ArrayHelper::remove($options, 'systemjs', []);
    Severity: Minor
    Found in src/systemjs/Module.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Possibly zero references to public method \ischenko\yii2\jsloader\SystemJs::init()
    Open

        public function init()
    Severity: Minor
    Found in src/SystemJs.php by phan

    Possibly zero write references to public property \ischenko\yii2\jsloader\SystemJs->position
    Open

        public $position;
    Severity: Minor
    Found in src/SystemJs.php by phan

    Possibly zero references to public method \ischenko\yii2\jsloader\systemjs\Config::toArray()
    Open

        public function toArray(): array
    Severity: Minor
    Found in src/systemjs/Config.php by phan

    Possibly zero references to public method \ischenko\yii2\jsloader\systemjs\Module::setExports()
    Open

        public function setExports($exports): ModuleInterface
    Severity: Minor
    Found in src/systemjs/Module.php by phan

    Returning type \ischenko\yii2\jsloader\systemjs\Config but getConfig() is declared to return \ischenko\yii2\jsloader\ConfigInterface
    Open

            return $this->config;
    Severity: Minor
    Found in src/SystemJs.php by phan
    Severity
    Category
    Status
    Source
    Language