Sign upLogin

isotopsweden/wp-cargo

View on GitHub
Star

Showing 2,470 of 2,470 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Isotop\Cargo\Admin;

use Isotop\Cargo\Content\Menus;
Severity: Major
Found in src/admin/menus.php and 1 other location - About 5 hrs to fix
src/admin/options.php on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Isotop\Cargo\Admin;

use Isotop\Cargo\Content\Options;
Severity: Major
Found in src/admin/options.php and 1 other location - About 5 hrs to fix
src/admin/menus.php on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function run_queue has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function run_queue() {
        $database = $this->cargo->make( 'database' );
        $pusher   = $this->cargo->make( 'pusher' );

        foreach ( $database->all() as $item ) {
Severity: Minor
Found in src/runner/class-basic.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepare_meta has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepare_meta( $object_id, $meta ) {
        if ( ! is_array( $meta ) ) {
            return [];
        }
Severity: Minor
Found in src/content/abstract-content.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_item has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function create_item( $menu, $parent_id, $post ) {
        $item = [];
        $type = get_post_meta( $post->ID, '_menu_item_type', true );

        switch ( $type ) {
Severity: Minor
Found in src/content/class-menus.php - About 1 hr to fix

    Avoid using undefined variables such as '$itme' which will lead to PHP notices.
    Open

                    $itme['url']           = '';
    Severity: Minor
    Found in src/content/class-menus.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Method prepare_meta has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function prepare_meta( $object_id, $meta ) {
        if ( ! is_array( $meta ) ) {
            return [];
        }
    Severity: Minor
    Found in src/content/abstract-content.php - About 1 hr to fix

      Method send has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function send( $data ) {
        $options = $this->cargo->config( 'pusher.http', ['url' => ''] );
        $options = is_array( $options ) ? $options : ['url' => ''];

        $json = $this->to_json( $data );
      Severity: Minor
      Found in src/pusher/class-http.php - About 1 hr to fix

        Function config has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function config( string $key, $default = null, array $source = [] ) {
        if ( isset( $source[$key] ) ) {
            return $source[$key];
        }
        Severity: Minor
        Found in src/class-cargo.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 12 and the first side effect is on line 35.
        Open

        <?php
        Severity: Minor
        Found in src/admin/options.php by phpcodesniffer

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 12 and the first side effect is on line 35.
        Open

        <?php
        Severity: Minor
        Found in src/admin/menus.php by phpcodesniffer

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 16 and the first side effect is on line 50.
        Open

        <?php
        Severity: Minor
        Found in src/admin/post.php by phpcodesniffer

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 15 and the first side effect is on line 29.
        Open

        <?php
        Severity: Minor
        Found in src/admin/user.php by phpcodesniffer

        Avoid variables with short names like $id. Configured minimum length is 3.
        Open

        function push_post_or_term( $id, $post = null ) {
        Severity: Minor
        Found in src/admin/post.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        The parameter $assoc_args is not named in camelCase.
        Open

            protected function get_format_args( $assoc_args ) {
        $format_args = [
            'fields' => $this->get_default_format_fields(),
            'field'  => null,
            'format' => 'table',
        Severity: Minor
        Found in src/cli/class-command.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $accepted_args is not named in camelCase.
        Open

            public function filter( string $tag, callable $fn, int $priority = 10, int $accepted_args = 1 ) {
        $fn = Closure::bind( Closure::fromCallable( $fn ), $this );

        if ( ! function_exists( 'add_filter' ) ) {
            throw new Exception( 'WordPress not loaded' );
        Severity: Minor
        Found in src/class-cargo.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $assoc_args is not named in camelCase.
        Open

            public function __invoke( $args, $assoc_args ) {
        $driver = $assoc_args['driver'] ?? 'basic';

        if ( isset( $assoc_args['all'] ) ) {
            cargo()->make( sprintf( 'driver.runner.%s', $driver ) )->run_all();
        Severity: Minor
        Found in src/cli/commands/class-run.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $user_id is not named in camelCase.
        Open

        function push_login( $user_id, $user ) {
    $data = new User( $user );

    // Send menu to pusher.
    $res = cargo()->make( 'pusher' )->send( $data );
        Severity: Minor
        Found in src/admin/user.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The class Abstract_Content is not named in CamelCase.
        Open

        abstract class Abstract_Content implements Content_Interface {

    /**
     * Content data.
     *
        Severity: Minor
        Found in src/content/abstract-content.php by phpmd

        CamelCaseClassName

        Since: 0.2

        It is considered best practice to use the CamelCase notation to name classes.

        Example

        class class_name {
}

        Source

        Avoid variables with short names like $fn. Configured minimum length is 3.
        Open

            public function filter( string $tag, callable $fn, int $priority = 10, int $accepted_args = 1 ) {
        Severity: Minor
        Found in src/class-cargo.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Severity
        Category
        Status
        Source
        Language