Sign upLogin

isprambiente/medplan

View on GitHub
Star

Showing 69 of 69 total issues

Function updateDateExpire has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  updateDateExpire(event) {
    var container, editor, inputDate, link, newDate, target, url, user_id;
    target = event.currentTarget;
    editor = target.parentNode;
    container = editor.parentNode;
Severity: Minor
Found in app/javascript/controllers/audits_controller.js - About 1 hr to fix

    Method set_data has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Confirmed

      def set_data(user, data = {})
    return if data.blank?

    user.username                 = data['login'] if user.username.blank? && data['login'].present?
    user.label                    = data['nominativo']
    Severity: Minor
    Found in app/jobs/users_checknew_job.rb - About 1 hr to fix

      Method users has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def users
    @filters = filter_params
    selected = {}
    selected[:city] = @filters[:city] if @filters[:city].present?
    selected[:postazione] = @filters[:postazione] if @filters[:postazione].present?
      Severity: Minor
      Found in app/controllers/home_controller.rb - About 1 hr to fix

        Function confirm_before_send has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          confirm_before_send(event) {
    var confirmation, deletable, form, icon, options, target, title;
    target = event.currentTarget;
    if (target.dataset.force !== 'true') {
      event.preventDefault();
        Severity: Minor
        Found in app/javascript/controllers/form_controller.js - About 1 hr to fix

          Method confirmed has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            def confirmed
    @meeting = @user.meetings.find_by(event: @event)
    @meeting.sended_at = Time.zone.now
    if @meeting.save && @user.email.present?
      if @event.status(@user) == 'proposed'
          Severity: Minor
          Found in app/controllers/events_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  btnSave.innerHTML = `<i class='fa fa-save' style=${target.dataset.fieldType === 'textarea' ? '' : 'padding-right:0px'}></i>${target.dataset.fieldType === 'textarea' ? ' Salva' : ''}`;
          Severity: Major
          Found in app/javascript/controllers/users_controller.js and 3 other locations - About 1 hr to fix
          app/javascript/controllers/users_controller.js on lines 142..142
          app/javascript/controllers/users_controller.js on lines 153..153
          app/javascript/controllers/users_controller.js on lines 160..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                    btnCanc.innerHTML = `<i class='fa fa-times' style=${target.dataset.fieldType === 'textarea' ? '' : 'padding-right:0px'}></i>${target.dataset.fieldType === 'textarea' ? ' Annulla' : ''}`;
          Severity: Major
          Found in app/javascript/controllers/users_controller.js and 3 other locations - About 1 hr to fix
          app/javascript/controllers/users_controller.js on lines 134..134
          app/javascript/controllers/users_controller.js on lines 142..142
          app/javascript/controllers/users_controller.js on lines 153..153

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method set_data has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def set_data(user, data = {})
    return if data.blank?

    user.username                 = data['login'] if user.username.blank? && data['login'].present?
    user.label                    = data['nominativo']
          Severity: Minor
          Found in app/jobs/users_checknew_job.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                    btnSave.innerHTML = `<i class='fa fa-save' style=${target.dataset.fieldType === 'textarea' ? '' : 'padding-right:0px'}></i>${target.dataset.fieldType === 'textarea' ? ' Salva' : ''}`;
          Severity: Major
          Found in app/javascript/controllers/users_controller.js and 3 other locations - About 1 hr to fix
          app/javascript/controllers/users_controller.js on lines 134..134
          app/javascript/controllers/users_controller.js on lines 142..142
          app/javascript/controllers/users_controller.js on lines 160..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  btnCanc.innerHTML = `<i class='fa fa-times' style=${target.dataset.fieldType === 'textarea' ? '' : 'padding-right:0px'}></i>${target.dataset.fieldType === 'textarea' ? ' Annulla' : ''}`;
          Severity: Major
          Found in app/javascript/controllers/users_controller.js and 3 other locations - About 1 hr to fix
          app/javascript/controllers/users_controller.js on lines 134..134
          app/javascript/controllers/users_controller.js on lines 153..153
          app/javascript/controllers/users_controller.js on lines 160..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                } else {
        el = document.createElement("INPUT");
        el.className = "input editor is-radiusless";
        el.style = "width:60%;";
        el.value = target.dataset.fieldValue;
          Severity: Major
          Found in app/javascript/controllers/users_controller.js and 1 other location - About 1 hr to fix
          app/javascript/controllers/users_controller.js on lines 44..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (target.dataset.fieldType === 'textarea') {
          el = document.createElement("TEXTAREA");
          el.className = "textarea editor is-radiusless";
          el.style = 'width:80%;';
          el.innerHTML = target.dataset.fieldValue;
          Severity: Major
          Found in app/javascript/controllers/users_controller.js and 1 other location - About 1 hr to fix
          app/javascript/controllers/users_controller.js on lines 110..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function editDateExpire has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            editDateExpire(event) {
    var btnCanc, btnSave, container, editDiv, el, oldDate, target;
    target = event.target;
    container = target.parentNode;
    editDiv = document.createElement("DIV");
          Severity: Minor
          Found in app/javascript/controllers/audits_controller.js - About 1 hr to fix

            Function confirmation has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              confirmation(event) {
    var confirmation, deletable, form, icon, options, target, title, url;
    target = event.target;
    confirmation = target.dataset.formConfirmation || '';
    url = target.dataset.formUrl;
            Severity: Minor
            Found in app/javascript/controllers/form_controller.js - About 1 hr to fix

              Function send has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                send(body = '') {
    var options;
    options = {
      width: '70%',
      heightAuto: true,
              Severity: Minor
              Found in app/javascript/controllers/calendar_controller.js - About 1 hr to fix

                Function send has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  send(body = '') {
    var options;
    options = {
      width: '70%',
      heightAuto: true,
                Severity: Minor
                Found in app/javascript/controllers/modal_controller.js - About 1 hr to fix

                  Function details has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    details(event) {
    var target, icon, container, info;

    target = event.currentTarget;
    if (target) {
                  Severity: Minor
                  Found in app/javascript/controllers/form_controller.js - About 1 hr to fix

                    Function Calendar has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      Calendar(target = this.calendarTarget) {
    var cal, url;

    url = target.dataset.calendarUrl;
    cal = new Calendar(target, {
                    Severity: Minor
                    Found in app/javascript/controllers/calendar_controller.js - About 1 hr to fix

                      Function success has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              success: (data, status, xhr) => {
          var td;
          this.send('Salvataggio avvenuto correttamente!');
          this.removeElement(target);
          link.text = moment(newDate).format("DD/MM/YYYY");
                      Severity: Minor
                      Found in app/javascript/controllers/audits_controller.js - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    } else {
              container.classList.add('active');
              container.classList.remove('expired');
              return link.closest("td").classList.remove('expired');
            }
                        Severity: Major
                        Found in app/javascript/controllers/audits_controller.js and 1 other location - About 1 hr to fix
                        app/javascript/controllers/audits_controller.js on lines 76..80

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language