app/controllers/concerns/utils.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method cleaned_layers_attributes has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def cleaned_layers_attributes(_params)
    _attrs = JSON.parse _params[:layers_attributes]
    _attrs.map do |layer|
      OpenStruct.new(
        id:           layer['id'].blank? ? nil : layer['id'].to_i,
Severity: Minor
Found in app/controllers/concerns/utils.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cleaned_relation_metadata has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def cleaned_relation_metadata(m)
    OpenStruct.new(
      description: m['description'].blank? ? nil : m['description'],
      start_date:  m['start_date'].blank? ? nil : Date.parse(m['start_date']),
      end_date:    m['end_date'].blank?   ? nil : Date.parse(m['end_date']),
Severity: Minor
Found in app/controllers/concerns/utils.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cleaned_relations_attributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def cleaned_relations_attributes(_params)
    _attrs = JSON.parse _params[:relations_attributes]
    _attrs.map do |r|
      OpenStruct.new(
        id:        (r['id'].blank? ? nil : r['id'].to_i    ),
Severity: Minor
Found in app/controllers/concerns/utils.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save_object has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def save_object(obj, params_hash)
    obj.assign_attributes(params_hash)
    changes = obj.changes
    if obj.valid? && obj.save
      obj_name = obj.class.name.underscore
Severity: Minor
Found in app/controllers/concerns/utils.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status