Sign upLogin

itachi1706/CheesecakeCapes

View on GitHub
Star
src/main/java/com/jadarstudios/developercapes/cape/AbstractCape.java

Summary

Maintainability
A
0 mins
Test Coverage

Change the visibility of this constructor to "protected".
Open

    public AbstractCape(String name) {
Severity: Major
Found in src/main/java/com/jadarstudios/developercapes/cape/AbstractCape.java by sonar-java

Abstract classes should not have public constructors. Constructors of abstract classes can only be called in constructors of their subclasses. So there is no point in making them public. The protected modifier should be enough.

Noncompliant Code Example

public abstract class AbstractClass1 {
    public AbstractClass1 () { // Noncompliant, has public modifier
        // do something here
    }
}

Compliant Solution

public abstract class AbstractClass2 {
    protected AbstractClass2 () {
        // do something here
    }
}

Change the visibility of this constructor to "protected".
Open

    public AbstractCape() {}
Severity: Major
Found in src/main/java/com/jadarstudios/developercapes/cape/AbstractCape.java by sonar-java

Abstract classes should not have public constructors. Constructors of abstract classes can only be called in constructors of their subclasses. So there is no point in making them public. The protected modifier should be enough.

Noncompliant Code Example

public abstract class AbstractClass1 {
    public AbstractClass1 () { // Noncompliant, has public modifier
        // do something here
    }
}

Compliant Solution

public abstract class AbstractClass2 {
    protected AbstractClass2 () {
        // do something here
    }
}

There are no issues that match your filters.

Category
Status