Sign upLogin

itachi1706/SingBuses

View on GitHub
Star
app/src/main/java/com/itachi1706/busarrivalsg/AsyncTasks/QueryNTUStops.java

Summary

Maintainability
A
0 mins
Test Coverage

Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed.
Open

    public Void doInBackground(Integer... stopIds) {
Severity: Critical
Found in app/src/main/java/com/itachi1706/busarrivalsg/AsyncTasks/QueryNTUStops.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Define a constant instead of duplicating this literal "" 6 times.
Open

            case 44478: return "<font color=\"red\">" + data + "</font>";
Severity: Critical
Found in app/src/main/java/com/itachi1706/busarrivalsg/AsyncTasks/QueryNTUStops.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

    public QueryNTUStops(Activity activity, String subtext, Callback onCompleteCallback) {
        super(TASK_NAME);
        this.actRef = new WeakReference<>(activity);
        this.originalSubtext = subtext;
        this.callback = onCompleteCallback;
Severity: Minor
Found in app/src/main/java/com/itachi1706/busarrivalsg/AsyncTasks/QueryNTUStops.java and 1 other location - About 35 mins to fix
app/src/main/java/com/itachi1706/busarrivalsg/AsyncTasks/PopulateListWithCurrentLocationRecycler.java on lines 47..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status