Sign upLogin

iterative/vscode-dvc

View on GitHub
Star

Showing 158 of 167 total issues

File index.ts has 758 lines of code (exceeds 300 allowed). Consider refactoring.
Open

import { Memento } from 'vscode'
import { SortDefinition, sortExperiments } from './sortBy'
import { FilterDefinition, filterExperiment, getFilterId } from './filterBy'
import { collectFiltered, collectUnfiltered } from './filterBy/collect'
import {
Severity: Major
Found in extension/src/experiments/model/index.ts - About 1 day to fix

    ExperimentsModel has 84 functions (exceeds 30 allowed). Consider refactoring.
    Open

    export class ExperimentsModel extends ModelWithPersistence {
  private workspace = {} as Experiment
  private cliError: undefined | string
  private commits: Experiment[] = []
  private experimentsByCommit: Map<string, Experiment[]> = new Map()
    Severity: Major
    Found in extension/src/experiments/model/index.ts - About 1 day to fix

      File index.ts has 640 lines of code (exceeds 300 allowed). Consider refactoring.
      Open

      import { join } from 'path'
import { Event, EventEmitter } from 'vscode'
import { Disposable, Disposer } from '@hediet/std/disposable'
import isEmpty from 'lodash.isempty'
import {
      Severity: Major
      Found in extension/src/setup/index.ts - About 1 day to fix

        File messages.ts has 534 lines of code (exceeds 300 allowed). Consider refactoring.
        Open

        import { commands, Uri, ViewColumn, window } from 'vscode'
import { StudioLinkType, TableData } from './contract'
import {
  RegisteredCliCommands,
  RegisteredCommands
        Severity: Major
        Found in extension/src/experiments/webview/messages.ts - About 7 hrs to fix

          File collect.ts has 488 lines of code (exceeds 300 allowed). Consider refactoring.
          Open

          import { sep } from 'path'
import { TemplatePlotGroup } from '../webview/contract'
import {
  EXPERIMENT_WORKSPACE_ID,
  ImagePlotOutput,
          Severity: Minor
          Found in extension/src/plots/paths/collect.ts - About 6 hrs to fix

            File collect.ts has 487 lines of code (exceeds 300 allowed). Consider refactoring.
            Open

            import get from 'lodash.get'
import type { TopLevelSpec } from 'vega-lite'
import {
  getContent,
  CustomPlotsOrderValue,
            Severity: Minor
            Found in extension/src/plots/model/collect.ts - About 6 hrs to fix

              Function constructor has 174 lines of code (exceeds 40 allowed). Consider refactoring.
              Open

                constructor(context: ExtensionContext) {
    super()

    const stopWatch = new StopWatch()
              Severity: Major
              Found in extension/src/extension.ts - About 6 hrs to fix

                File messages.ts has 477 lines of code (exceeds 300 allowed). Consider refactoring.
                Open

                import { join } from 'path'
import { commands } from 'vscode'
import isEmpty from 'lodash.isempty'
import {
  ComparisonPlot,
                Severity: Minor
                Found in extension/src/plots/webview/messages.ts - About 6 hrs to fix

                  Setup has 51 functions (exceeds 30 allowed). Consider refactoring.
                  Open

                  export class Setup
  extends BaseRepository<TSetupData>
  implements IExtensionSetup
{
  public readonly viewKey = ViewKey.SETUP
                  Severity: Major
                  Found in extension/src/setup/index.ts - About 5 hrs to fix

                    Function useDragAndDrop has a Cognitive Complexity of 36 (exceeds 6 allowed). Consider refactoring.
                    Open

                    export const useDragAndDrop = ({
  id,
  disabledDropIds = [],
  shouldShowOnDrag,
  onDragEnd,
                    Severity: Minor
                    Found in webview/src/shared/hooks/useDragAndDrop.tsx - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File index.ts has 432 lines of code (exceeds 300 allowed). Consider refactoring.
                    Open

                    import { Memento } from 'vscode'
import {
  collectData,
  collectSelectedTemplatePlots,
  collectTemplatesDetails,
                    Severity: Minor
                    Found in extension/src/plots/model/index.ts - About 5 hrs to fix

                      File collect.ts has 415 lines of code (exceeds 300 allowed). Consider refactoring.
                      Open

                      import {
  MarkdownString,
  ThemeIcon,
  TreeItemCollapsibleState,
  Uri
                      Severity: Minor
                      Found in extension/src/experiments/model/collect.ts - About 4 hrs to fix

                        Function TemplatePlots has 130 lines of code (exceeds 40 allowed). Consider refactoring.
                        Open

                        export const TemplatePlots: React.FC = () => {
  const { nbItemsPerRow, sections, hasItems, shouldShowTooManyPlotsMessage } =
    useSelector((state: PlotsState) => state.template)

  const draggedOverGroup = useSelector(
                        Severity: Major
                        Found in webview/src/plots/components/templatePlots/TemplatePlots.tsx - About 4 hrs to fix

                          File index.ts has 402 lines of code (exceeds 300 allowed). Consider refactoring.
                          Open

                          import {
  basename,
  extname,
  join,
  parse,
                          Severity: Minor
                          Found in extension/src/fileSystem/index.ts - About 4 hrs to fix

                            Function handleMessageFromWebview has 125 lines of code (exceeds 40 allowed). Consider refactoring.
                            Open

                              public handleMessageFromWebview(message: MessageFromWebview) {
    // eslint-disable-next-line sonarjs/max-switch-cases
    switch (message.type) {
      case MessageFromWebviewType.REORDER_COLUMNS:
        return this.setColumnOrder(message.payload)
                            Severity: Major
                            Found in extension/src/experiments/webview/messages.ts - About 4 hrs to fix

                              File RowContextMenu.tsx has 398 lines of code (exceeds 300 allowed). Consider refactoring.
                              Open

                              import React, { useMemo } from 'react'
import { useDispatch, useSelector } from 'react-redux'
import {
  MessageFromWebview,
  MessageFromWebviewType
                              Severity: Minor
                              Found in webview/src/experiments/components/table/body/RowContextMenu.tsx - About 4 hrs to fix

                                PlotsModel has 43 functions (exceeds 30 allowed). Consider refactoring.
                                Open

                                export class PlotsModel extends ModelWithPersistence {
  private readonly experiments: Experiments
  private readonly errors: ErrorsModel

  private nbItemsPerRowOrWidth: Record<PlotsSection, number>
                                Severity: Minor
                                Found in extension/src/plots/model/index.ts - About 4 hrs to fix

                                  File collect.ts has 383 lines of code (exceeds 300 allowed). Consider refactoring.
                                  Open

                                  import { join, relative, resolve, sep } from 'path'
import { Uri } from 'vscode'
import { Resource } from '../commands'
import { addToMapSet } from '../../util/map'
import { Changes, DataStatusOutput } from '../../cli/dvc/contract'
                                  Severity: Minor
                                  Found in extension/src/repository/model/collect.ts - About 4 hrs to fix

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                      constructor(
    plots: WorkspacePlots,
    internalCommands: InternalCommands,
    resourceLocator: ResourceLocator
  ) {
                                    Severity: Major
                                    Found in extension/src/plots/paths/tree.ts and 1 other location - About 3 hrs to fix
                                    extension/src/experiments/columns/tree.ts on lines 14..33

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 114.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                      constructor(
    experiments: WorkspaceExperiments,
    internalCommands: InternalCommands,
    resourceLocator: ResourceLocator
  ) {
                                    Severity: Major
                                    Found in extension/src/experiments/columns/tree.ts and 1 other location - About 3 hrs to fix
                                    extension/src/plots/paths/tree.ts on lines 24..43

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 114.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language