Sign upLogin

itsapi/github-listener

View on GitHub
Star

Showing 17 of 17 total issues

Function BuildManager has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var BuildManager = function(elem) {
  var self = this;

  self.elem = elem;
  self.builds = {};
Severity: Major
Found in static/main.js - About 2 hrs to fix

Function Server has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Server = function (options, ready) {
  var self = this;

  self.port = options.port || 6003;
  self.config = options.config;
Severity: Minor
Found in src/server.js - About 1 hr to fix

Function start has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Server.prototype.start = function () {
  var self = this;

  // Start the server
  self.app.listen(self.port, function () {
Severity: Minor
Found in src/server.js - About 1 hr to fix

Function Travis has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Travis = (function () {
  var travis_parser = function () { Parser.apply(this, arguments); };
  util.inherits(travis_parser, Parser);

  travis_parser.prototype.parse_body = function () {
Severity: Minor
Found in src/parser.js - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  gh_parser.prototype.parse_body = function () {
    try { return (this.payload = JSON.parse(this.body)); }
    catch (e) { return undefined; }
  };
Severity: Major
Found in src/parser.js and 1 other location - About 1 hr to fix
src/parser.js on lines 57..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  gl_parser.prototype.parse_body = function () {
    try { return (this.payload = JSON.parse(this.body)); }
    catch (e) { return undefined; }
  };
Severity: Major
Found in src/parser.js and 1 other location - About 1 hr to fix
src/parser.js on lines 22..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function GitLab has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var GitLab = (function () {
  var gl_parser = function () { Parser.apply(this, arguments); };
  util.inherits(gl_parser, Parser);

  gl_parser.prototype.parse_body = function () {
Severity: Minor
Found in src/parser.js - About 1 hr to fix

Function check_payload has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Build.prototype.check_payload = function () {
  var self = this;

  function error (code, message) {
    self.err = true;
Severity: Minor
Found in src/build.js - About 1 hr to fix

Function GitHub has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var GitHub = (function () {
  var gh_parser = function () { Parser.apply(this, arguments); };
  util.inherits(gh_parser, Parser);

  gh_parser.prototype.parse_body = function () {
Severity: Minor
Found in src/parser.js - About 1 hr to fix

Function GitHub has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

var GitHub = (function () {
  var gh_parser = function () { Parser.apply(this, arguments); };
  util.inherits(gh_parser, Parser);

  gh_parser.prototype.parse_body = function () {
Severity: Minor
Found in src/parser.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Travis has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

var Travis = (function () {
  var travis_parser = function () { Parser.apply(this, arguments); };
  util.inherits(travis_parser, Parser);

  travis_parser.prototype.parse_body = function () {
Severity: Minor
Found in src/parser.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GitLab has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

var GitLab = (function () {
  var gl_parser = function () { Parser.apply(this, arguments); };
  util.inherits(gl_parser, Parser);

  gl_parser.prototype.parse_body = function () {
Severity: Minor
Found in src/parser.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

    if (!(this.payload.repository &&
          this.payload.repository.git_ssh_url &&
          this.payload.repository.homepage &&
          this.payload.ref &&
          this.payload.total_commits_count &&
Severity: Major
Found in src/parser.js - About 40 mins to fix

Function Build has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

var Build = function (req, res, payload, build_manager, id) {
Severity: Minor
Found in src/build.js - About 35 mins to fix

Function check_payload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

Build.prototype.check_payload = function () {
  var self = this;

  function error (code, message) {
    self.err = true;
Severity: Minor
Found in src/build.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Server has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

var Server = function (options, ready) {
  var self = this;

  self.port = options.port || 6003;
  self.config = options.config;
Severity: Minor
Found in src/server.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function serve has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

Server.prototype.serve = function (req, res) {
  var self = this;

  if (req.pathname === '/') {
    if (req.query.rebuild !== undefined) { // Rebuild last_payload
Severity: Minor
Found in src/server.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language