Sign upLogin

ivanprjcts/sdklib

View on GitHub
Star
sdklib/http/base.py

Summary

Maintainability
D
2 days
Test Coverage

File base.py has 439 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import copy
import urllib3
import ssl
import os
Severity: Minor
Found in sdklib/http/base.py - About 6 hrs to fix

    HttpRequestContext has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class HttpRequestContext(object):
    """
    Context object used to save http request parameters.
    """
    Severity: Minor
    Found in sdklib/http/base.py - About 3 hrs to fix

      Cyclomatic complexity is too high in function request_from_context. (10)
      Open

      def request_from_context(context):
    """
    Do http requests from context.

    :param context: request context.
      Severity: Minor
      Found in sdklib/http/base.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function __init__ has 19 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Major
      Found in sdklib/http/base.py - About 2 hrs to fix

        Cyclomatic complexity is too high in function generate_url_path. (6)
        Open

        def generate_url_path(
        url_path_format, prefix=None, format_suffix=None, allow_key_errors=True, **kwargs
):
    prefix = prefix or ''
    suffix = ensure_url_path_format_suffix_starts_with_dot(format_suffix)
        Severity: Minor
        Found in sdklib/http/base.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Function generate_url_path has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        def generate_url_path(
        url_path_format, prefix=None, format_suffix=None, allow_key_errors=True, **kwargs
):
    prefix = prefix or ''
    suffix = ensure_url_path_format_suffix_starts_with_dot(format_suffix)
        Severity: Minor
        Found in sdklib/http/base.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _http_request has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def _http_request(
        Severity: Major
        Found in sdklib/http/base.py - About 50 mins to fix

          Function request_from_context has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def request_from_context(context):
    """
    Do http requests from context.

    :param context: request context.
          Severity: Minor
          Found in sdklib/http/base.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function post has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def post(
          Severity: Minor
          Found in sdklib/http/base.py - About 45 mins to fix

            Function put has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def put(
            Severity: Minor
            Found in sdklib/http/base.py - About 45 mins to fix

              Function patch has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def patch(
              Severity: Minor
              Found in sdklib/http/base.py - About 45 mins to fix

                Function generate_url_path has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def generate_url_path(
                Severity: Minor
                Found in sdklib/http/base.py - About 35 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      def put(
            self, url_path, headers=None, query_params=None, body_params=None, files=None, **kwargs
    ):
        return self._http_request(PUT_METHOD, url_path, headers, query_params, body_params, files,
                  Severity: Minor
                  Found in sdklib/http/base.py and 2 other locations - About 30 mins to fix
                  sdklib/http/base.py on lines 486..489
                  sdklib/http/base.py on lines 498..501

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 32.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      def patch(
            self, url_path, headers=None, query_params=None, body_params=None, files=None, **kwargs
    ):
        return self._http_request(PATCH_METHOD, url_path, headers, query_params, body_params, files,
                  Severity: Minor
                  Found in sdklib/http/base.py and 2 other locations - About 30 mins to fix
                  sdklib/http/base.py on lines 486..489
                  sdklib/http/base.py on lines 492..495

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 32.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      def post(
            self, url_path, headers=None, query_params=None, body_params=None, files=None, **kwargs
    ):
        return self._http_request(POST_METHOD, url_path, headers, query_params, body_params, files,
                  Severity: Minor
                  Found in sdklib/http/base.py and 2 other locations - About 30 mins to fix
                  sdklib/http/base.py on lines 492..495
                  sdklib/http/base.py on lines 498..501

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 32.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status