ixarlie/mutex-bundle

View on GitHub
src/MutexRequest.php

Summary

Maintainability
A
0 mins
Test Coverage

The method __construct has a boolean flag argument $userIsolation, which is a certain sign of a Single Responsibility Principle violation.
Open

        public readonly bool    $userIsolation = false,
Severity: Minor
Found in src/MutexRequest.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The first parameter of a multi-line function declaration must be on the line after the opening bracket
Open

        public readonly string  $service,
Severity: Minor
Found in src/MutexRequest.php by phpcodesniffer

Arguments with default values must be at the end of the argument list
Open

        public readonly bool    $userIsolation = false,
Severity: Minor
Found in src/MutexRequest.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly ?string $message = null,
Severity: Minor
Found in src/MutexRequest.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly ?float  $ttl = 300.0,
Severity: Minor
Found in src/MutexRequest.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly string  $strategy,
Severity: Minor
Found in src/MutexRequest.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly string  $service,
Severity: Minor
Found in src/MutexRequest.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public ?string          $name = null,
Severity: Minor
Found in src/MutexRequest.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public readonly bool    $userIsolation = false,
Severity: Minor
Found in src/MutexRequest.php by phpcodesniffer

There are no issues that match your filters.

Category
Status