Sign upLogin

iyard/project-lvl2-s459

View on GitHub
Star

Showing 10 of 10 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function getRecurseData($data, $level)
{
    $recurseData = array_map(function ($key) use ($data, $level) {
        return [PHP_EOL . getOffset($level + 1) . "    {$key}: {$data[$key]}"];
    }, array_keys($data));
Severity: Major
Found in src/renderers/Pretty.php and 1 other location - About 3 hrs to fix
src/views/Pretty.php on lines 50..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function getRecurseData($data, $level)
{
    $recurseData = array_map(function ($key) use ($data, $level) {
        return [PHP_EOL . getOffset($level + 1) . "    {$key}: {$data[$key]}"];
    }, array_keys($data));
Severity: Major
Found in src/views/Pretty.php and 1 other location - About 3 hrs to fix
src/renderers/Pretty.php on lines 51..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method getPretty has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getPretty($data, $level)
{
        ['type' => $type,
        'key' => $key,
        'valueBefore' => $valueBefore,
Severity: Minor
Found in src/renderers/Pretty.php - About 1 hr to fix

    Method getPretty has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getPretty($data, $level)
{
        ['type' => $type,
        'key' => $key,
        'valueBefore' => $valueBefore,
    Severity: Minor
    Found in src/views/Pretty.php - About 1 hr to fix

      Function buildAst has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function buildAst($dataBefore, $dataAfter)
{
    $keys = union(array_keys($dataBefore), array_keys($dataAfter));
    $accumulateData = function ($acc, $key) use ($dataBefore, $dataAfter) {
        $valuePrepareBefore = $dataBefore[$key] ?? '';
      Severity: Minor
      Found in src/Ast.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildNodeStructure has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function buildNodeStructure($type, $key, $valueBefore, $valueAfter, $children)
      Severity: Minor
      Found in src/Ast.php - About 35 mins to fix

        Avoid too many return statements within this method.
        Open

                        return getOffset($level) . "  + {$key}: {$valueAfter}";
        Severity: Major
        Found in src/renderers/Pretty.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return getOffset($level) . "  + {$key}: {$valueAfter}";
          Severity: Major
          Found in src/views/Pretty.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return getOffset($level) . "  - {$key}: {$valueBefore}";
            Severity: Major
            Found in src/renderers/Pretty.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return "Property '{$nodeFullKey}' was added with value: '{$valueAfter}'";
              Severity: Major
              Found in src/renderers/Plain.php - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language