Sign upLogin

jackkum/PHPPDU

View on GitHub
Star
PDU/DCS.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function getValue has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function getValue()
    {
        $this->_encodeGroup = 0x00;
        
        // set data encoding, from alphabet and message class
Severity: Minor
Found in PDU/DCS.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getValue has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getValue()
    {
        $this->_encodeGroup = 0x00;
        
        // set data encoding, from alphabet and message class
Severity: Minor
Found in PDU/DCS.php - About 1 hr to fix

    Function parse has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function parse()
    {
        $DCS  = new self();
        $byte = hexdec(PDU::getPduSubstr(2));
    Severity: Minor
    Found in PDU/DCS.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function parse()
    {
        $DCS  = new self();
        $byte = hexdec(PDU::getPduSubstr(2));
    Severity: Minor
    Found in PDU/DCS.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status