Sign upLogin

jackkum/PHPPDU

View on GitHub
Star
PDU/SCA.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method parse has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function parse($isAddress = TRUE)
    {
        $SCA     = new self($isAddress);
        $size    = hexdec(PDU::getPduSubstr(2));
Severity: Minor
Found in PDU/SCA.php - About 1 hr to fix

    Function parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function parse($isAddress = TRUE)
    {
        $SCA     = new self($isAddress);
        $size    = hexdec(PDU::getPduSubstr(2));
    Severity: Minor
    Found in PDU/SCA.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                case 0x0E: return "c";
    Severity: Major
    Found in PDU/SCA.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  default: return $letter;
      Severity: Major
      Found in PDU/SCA.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    default: return $letter;
        Severity: Major
        Found in PDU/SCA.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      case "c": return 'E';
          Severity: Major
          Found in PDU/SCA.php - About 30 mins to fix

            Function __toString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __toString()
    {
        $PDU = sprintf("%02X", $this->getSize());
        
        if($this->getSize()){
            Severity: Minor
            Found in PDU/SCA.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status