Sign upLogin

jackkum/PHPPDU

View on GitHub
Star
PDU/VP.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function __toString has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function __toString()
    {
        // get pdu type
        $type = $this->getPdu()->getType();
Severity: Minor
Found in PDU/VP.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public static function parse(Submit $pdu)
    {
        $vp = new self($pdu);
        
        switch($pdu->getType()->getVpf()){
Severity: Minor
Found in PDU/VP.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return sprintf("%02X", ($weeks > 63 ? 63 : $weeks)+192);
Severity: Major
Found in PDU/VP.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return "";
    Severity: Major
    Found in PDU/VP.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status