Sign upLogin

jackkum/PHPPDU

View on GitHub
Star

Showing 23 of 23 total issues

Avoid too many return statements within this method.
Open

            default: return $letter;
Severity: Major
Found in PDU/SCA.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                case "c": return 'E';
    Severity: Major
    Found in PDU/SCA.php - About 30 mins to fix

      Function __toString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __toString()
    {
        $PDU = sprintf("%02X", $this->getSize());
        
        if($this->getSize()){
      Severity: Minor
      Found in PDU/SCA.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language