Sign upLogin

jacobemerick/archangel

View on GitHub
Star
src/Archangel.php

Summary

Maintainability
B
7 hrs
Test Coverage

The class Archangel has an overall complexity of 54 which is very high. The configured complexity threshold is 50.
Open

class Archangel implements LoggerAwareInterface
{

    /** @var boolean $isTestMode */
    protected $isTestMode;
Severity: Minor
Found in src/Archangel.php by phpmd

File Archangel.php has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Jacobemerick\Archangel;

use Psr\Log\LoggerAwareInterface;
Severity: Minor
Found in src/Archangel.php - About 2 hrs to fix

    Archangel has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Archangel implements LoggerAwareInterface
{

    /** @var boolean $isTestMode */
    protected $isTestMode;
    Severity: Minor
    Found in src/Archangel.php - About 2 hrs to fix

      Method buildMessageWithAttachments has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function buildMessageWithAttachments()
    {
        $message = array();

        if (!empty($this->plainMessage) || !empty($this->htmlMessage)) {
      Severity: Minor
      Found in src/Archangel.php - About 1 hr to fix

        Function buildHeaders has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function buildHeaders()
    {
        $headers = array();
        foreach ($this->headers as $key => $value) {
            if ($key == 'CC' || $key == 'BCC') {
        Severity: Minor
        Found in src/Archangel.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildMessageWithAttachments has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function buildMessageWithAttachments()
    {
        $message = array();

        if (!empty($this->plainMessage) || !empty($this->htmlMessage)) {
        Severity: Minor
        Found in src/Archangel.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method __construct has a boolean flag argument $isTestMode, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function __construct($mailer = null, $isTestMode = false)
        Severity: Minor
        Found in src/Archangel.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        There are no issues that match your filters.

        Category
        Status