jacobemerick/web

View on GitHub

Showing 34 of 34 total issues

Function imageLightbox has 229 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  $.fn.imageLightbox = function( options )
  {
    var options    = $.extend(
             {
              selector:   'id="imagelightbox"',
Severity: Major
Found in public/js/imagelightbox.js - About 1 day to fix

    Function loadImage has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          loadImage = function( direction )
          {
            if( inProgress ) return false;
    
            direction = typeof direction === 'undefined' ? false : direction == 'left' ? 1 : -1;
    Severity: Major
    Found in public/js/imagelightbox.js - About 4 hrs to fix

      Function exports has 98 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {
        grunt.config('env', grunt.option('env') || 'dev');
      
        grunt.loadNpmTasks('grunt-bowercopy');
        grunt.loadNpmTasks('grunt-contrib-clean');
      Severity: Major
      Found in Gruntfile.js - About 3 hrs to fix

        Method get_direct_array has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function get_direct_array()
            {
                return array(
                    (object) array(
                        'match' => '/',
        Severity: Major
        Found in router/WaterfallRouter.class.inc.php - About 2 hrs to fix

          File imagelightbox.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          
          /*
            By Osvaldas Valutis, www.osvaldas.info
            Available for use under the MIT License
          */
          Severity: Minor
          Found in public/js/imagelightbox.js - About 2 hrs to fix

            Method get_redirect_array has 62 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function get_redirect_array()
                {
                    return array(
                        (object) array(
                            'pattern' => '@/index.(html|htm|php)$@',
            Severity: Major
            Found in router/WaterfallRouter.class.inc.php - About 2 hrs to fix

              Function check_for_special_redirect has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function check_for_special_redirect($uri)
                  {
                      if (preg_match('@^/falls/([a-z\'-]+)(/?)$@', $uri, $matches)) {
                          $alias = $matches[1];
                          $alias = str_replace("'", '', $alias);
              Severity: Minor
              Found in router/WaterfallRouter.class.inc.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method process_form_data has 49 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function process_form_data()
                  {
                      $errors = [];
              
                      if (
              Severity: Minor
              Found in controller/portfolio/ContactController.class.inc.php - About 1 hr to fix

                Method check_for_special_redirect has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function check_for_special_redirect($uri)
                    {
                        if (preg_match('@^/falls/([a-z\'-]+)(/?)$@', $uri, $matches)) {
                            $alias = $matches[1];
                            $alias = str_replace("'", '', $alias);
                Severity: Minor
                Found in router/WaterfallRouter.class.inc.php - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php
                  
                  namespace Jacobemerick\Web\Domain\Waterfall\Log;
                  
                  use Aura\Sql\ConnectionLocator;
                  Severity: Major
                  Found in src/Domain/Waterfall/Log/MysqlLogRepository.php and 1 other location - About 1 hr to fix
                  src/Domain/Waterfall/Waterfall/MysqlWaterfallRepository.php on lines 1..44

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 116.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php
                  
                  namespace Jacobemerick\Web\Domain\Waterfall\Waterfall;
                  
                  use Aura\Sql\ConnectionLocator;
                  Severity: Major
                  Found in src/Domain/Waterfall/Waterfall/MysqlWaterfallRepository.php and 1 other location - About 1 hr to fix
                  src/Domain/Waterfall/Log/MysqlLogRepository.php on lines 1..42

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 116.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method getWatercourseList has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getWatercourseList()
                      {
                          $query = "
                              SELECT `sum_table`.`name`, `sum_table`.`alias`, SUM(`count`) AS `count`
                              FROM ((
                  Severity: Minor
                  Found in src/Domain/Waterfall/Watercourse/MysqlWatercourseRepository.php - About 1 hr to fix

                    Method save has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function save(array $data)
                        {
                            $path = $_SERVER['REQUEST_URI'];
                            $path = explode('/', $path);
                            $path = array_filter($path);
                    Severity: Minor
                    Found in module/form/CommentSubmitModule.class.inc.php - About 1 hr to fix

                      Method checkRequest has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public static function checkRequest($type, $key, $validation, $strict = false)
                          {
                              switch($type)
                              {
                                  case 'server':
                      Severity: Minor
                      Found in utility/Validate.class.inc.php - About 1 hr to fix

                        Method getActivePostsByRelatedTags has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getActivePostsByRelatedTags($post, $limit = 4)
                            {
                                $query = "
                                    SELECT `id`, `title`, `path`, `date`, `body`, `category`, COUNT(1) AS `count`
                                    FROM `jpemeric_blog`.`post`
                        Severity: Minor
                        Found in src/Domain/Blog/Post/MysqlPostRepository.php - About 1 hr to fix

                          Method form_url_array has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              static private function form_url_array($host, $uri)
                              {
                                  $uri = substr($uri, 1);
                                  if(strpos($uri, '?'))
                                      $uri = substr($uri, 0, strpos($uri, '?'));
                          Severity: Minor
                          Found in utility/URLDecode.class.inc.php - About 1 hr to fix

                            Consider simplifying this complex logical expression.
                            Open

                                      if( direction !== false && ( targets.length < 2 || ( options.quitOnEnd === true && ( ( direction === -1 && targets.index( target ) == 0 ) || ( direction === 1 && targets.index( target ) == targets.length - 1 ) ) ) ) )
                                      {
                                        quitLightbox();
                                        return false;
                                      }
                            Severity: Major
                            Found in public/js/imagelightbox.js - About 1 hr to fix

                              Function load has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public static function load($type, $files, $data = array())
                                  {
                                      foreach((array) $files as $file)
                                      {
                                          $file_path = self::instance()->get_path($type, $file);
                              Severity: Minor
                              Found in utility/Loader.class.inc.php - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function checkValidation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private function checkValidation()
                                  {
                                      $errors = array();
                                      if (!Validate::checkRequest('post', 'name', 'name')) {
                                          $errors['name'] = 'You must include a valid name';
                              Severity: Minor
                              Found in module/form/CommentSubmitModule.class.inc.php - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method getComments has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public function getComments($domain = null, $path = null, $page = null, $perPage = null, $order = null);
                              Severity: Minor
                              Found in src/Domain/Comment/Comment/CommentRepositoryInterface.php - About 35 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language