Sign upLogin

jaimeiniesta/metainspector

View on GitHub
Star

Showing 6 of 6 total issues

Method fetch has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def fetch
      Timeout::timeout(fatal_timeout) do
        @faraday_options.merge!(:url => url)
        follow_redirects_options = @faraday_options.delete(:redirect) || {}
Severity: Minor
Found in lib/meta_inspector/request.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fetch has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def fetch
      Timeout::timeout(fatal_timeout) do
        @faraday_options.merge!(:url => url)
        follow_redirects_options = @faraday_options.delete(:redirect) || {}
Severity: Minor
Found in lib/meta_inspector/request.rb - About 1 hr to fix

    Method to_hash has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def to_hash
      {
        'url'              => url,
        'scheme'           => scheme,
        'host'             => host,
    Severity: Minor
    Found in lib/meta_inspector/document.rb - About 1 hr to fix

      Method meta_tags_by has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def meta_tags_by(attribute)
        hash = {}
        parsed.css("meta[@#{attribute}]").map do |tag|
          name    = tag.attributes[attribute].value.downcase rescue nil
          content = tag.attributes['content'].value rescue nil
      Severity: Minor
      Found in lib/meta_inspector/parsers/meta_tags.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method absolutify has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.absolutify(url, base_url, options = {})
      options = defaults.merge(options)
      if url =~ /^\w*\:/i
        MetaInspector::URL.new(url, options).url
      else
      Severity: Minor
      Found in lib/meta_inspector/url.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def read
      return unless response
      body = response.body
      body = body.encode!(@encoding, @encoding, :invalid => :replace) if @encoding
      body.tr("\000", '')
      Severity: Minor
      Found in lib/meta_inspector/request.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language