Sign upLogin

jaimeiniesta/site_validator

View on GitHub
Star
lib/site_validator/sitemap.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method pages_in_sitemap has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def pages_in_sitemap
      pages = xml_locations.select {|loc| looks_like_html?(loc.text.strip)}.map {|loc| SiteValidator::Page.new(loc.text.strip)}

      if pages.empty?
        m     = scraped_doc
Severity: Minor
Found in lib/site_validator/sitemap.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method looks_like_html? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def looks_like_html?(url)
      u         = URI.parse(URI.encode(url))
      scheme    = u.scheme                if u.scheme
      extension = u.path.split(".").last  if u.path && u.path.split(".").size > 1
Severity: Minor
Found in lib/site_validator/sitemap.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status