jameshawkinsjr/hype

View on GitHub
frontend/components/chat/chatroom_add.jsx

Summary

Maintainability
F
1 wk
Test Coverage

Function render has 226 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render () {

        let errors = this.props.errors.map( error => 
            <li key={error}> {error} </li> 
            )
Severity: Major
Found in frontend/components/chat/chatroom_add.jsx - About 1 day to fix

    File chatroom_add.jsx has 339 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from 'react';
    import { Link } from 'react-router-dom';
    import Cable from 'actioncable';
    
    
    
    Severity: Minor
    Found in frontend/components/chat/chatroom_add.jsx - About 4 hrs to fix

      Function render has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          render () {
      
              let errors = this.props.errors.map( error => 
                  <li key={error}> {error} </li> 
                  )
      Severity: Minor
      Found in frontend/components/chat/chatroom_add.jsx - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function displayChannelList has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                                  {   this.state.chatrooms.map( chatroom => {
                                      { if (chatroom.chatroom_type === 'channel' && chatroom.title.toLowerCase().includes(this.state.inputBox.toLowerCase()) ) {
                                          return (
                                              <Link   key={`chatroom-${chatroom.id}`} 
                                                      to={`/chatrooms/${chatroom.id}`}
      Severity: Minor
      Found in frontend/components/chat/chatroom_add.jsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            <ul className="create-channel-user-list join-channel-user-list flex">
                                {   
                                    this.state.users.map( user => {
                                        if ( user.id === this.props.currentUser.id || user.full_name === "Hypebot"){
                                            return ""
        Severity: Major
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 2 days to fix
        frontend/components/chat/chatroom_add.jsx on lines 177..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 409.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        <ul className="join-channel-user-list flex">
                                {   
                                    
                                    this.state.users.map( user => {
                                        if ( user.id === this.props.currentUser.id || user.full_name === "Hypebot"){
        Severity: Major
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 2 days to fix
        frontend/components/chat/chatroom_add.jsx on lines 305..331

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 409.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                { this.state.directMessageUsers.map ( user => ( 
                                    <div key={`user4-${user}`} className="individual-user flex" onClick={ () => this.removeUser(user)}> 
                                        <span className="individual-user-box"> {user} </span> 
                                        <span className="individual-user-x"> <i className="fas fa-times"></i></span> 
                                        
        Severity: Major
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 4 hrs to fix
        frontend/components/chat/chatroom_add.jsx on lines 290..297

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 129.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            { this.state.directMessageUsers.map ( user => ( 
                                    <div key={`user3-${user}`} className="individual-user flex" onClick={ () => this.removeUser(user)}> 
                                        <span className="individual-user-box"> {user} </span> 
                                        <span className="individual-user-x"> <i className="fas fa-times"></i></span> 
                                        
        Severity: Major
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 4 hrs to fix
        frontend/components/chat/chatroom_add.jsx on lines 147..154

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 129.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                let renderErrors = (
                    <div className="errors-box flex">
                        <div className="error-red"><pre> </pre></div>
                        <ul className="errors">
                                { errors } 
        Severity: Major
        Found in frontend/components/chat/chatroom_add.jsx and 3 other locations - About 1 hr to fix
        frontend/components/messages/message_item_edit.jsx on lines 46..53
        frontend/components/session/login_form.jsx on lines 88..95
        frontend/components/session/signup_form.jsx on lines 43..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            handleEnterKey(e) {
                if (e.key === 'Enter') {
                    this.handleSubmit(e);
                } else if (e.key === "Escape"){
                    this.props.closeModal();
        Severity: Major
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 1 hr to fix
        frontend/components/messages/message_item_edit.jsx on lines 32..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                    <input  type="text"
                                            placeholder="Search Channels"
                                            onChange={this.handleInput('inputBox')}
                                            autoFocus
                                            onKeyDown={ (e) => this.handleEnterKey(e) }
        Severity: Minor
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 55 mins to fix
        frontend/components/chat/chatroom_add.jsx on lines 155..160

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                <input  type="text"
                                        placeholder="Find a user"
                                        onChange={this.handleInput('inputBox')}
                                        autoFocus
                                        onKeyDown={ (e) => this.handleEnterKey(e) }
        Severity: Minor
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 55 mins to fix
        frontend/components/chat/chatroom_add.jsx on lines 221..226

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

                let errors = this.props.errors.map( error => 
                    <li key={error}> {error} </li> 
                    )
        Severity: Major
        Found in frontend/components/chat/chatroom_add.jsx and 3 other locations - About 40 mins to fix
        frontend/components/messages/message_item_edit.jsx on lines 42..44
        frontend/components/session/login_form.jsx on lines 84..86
        frontend/components/session/signup_form.jsx on lines 39..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status