Sign upLogin

jameshawkinsjr/hype

View on GitHub
Star

Showing 78 of 78 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export const editChatroom = (chatroom) => (
    $.ajax({
        method: 'PATCH',
        url: `/api/chatrooms/${chatroom.id}`,
        data: { chatroom }
Severity: Major
Found in frontend/util/chatrooms_api_util.js and 3 other locations - About 1 hr to fix
frontend/util/chatrooms_api_util.js on lines 45..51
frontend/util/chatrooms_api_util.js on lines 53..59
frontend/util/messages_api_util.js on lines 30..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export const editMessage = (message) => (
    $.ajax({
        method: 'PATCH',
        url: `/api/messages/${message.id}`,
        data: { message }
Severity: Major
Found in frontend/util/messages_api_util.js and 3 other locations - About 1 hr to fix
frontend/util/chatrooms_api_util.js on lines 22..28
frontend/util/chatrooms_api_util.js on lines 45..51
frontend/util/chatrooms_api_util.js on lines 53..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Footer has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Footer = () => {

    return (
        <div className="footer flex">
                <div className="footer-left">
Severity: Minor
Found in frontend/components/templates/footer.jsx - About 1 hr to fix

    Function render has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        let name;
        if (this.props.currentUser) {
            if (this.props.currentUser.alias) {
                name = this.props.currentUser.alias;
    Severity: Minor
    Found in frontend/components/navbar/navbar.jsx - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          unsubscribe(chatroom){
        this.props.unsubscribeFromChatroom(chatroom)
        .then( () => this.props.history.push(`/chatrooms/1`) );
    }
      Severity: Major
      Found in frontend/components/chat/chatroom_list.jsx and 1 other location - About 1 hr to fix
      frontend/components/chat/chatroom_header.jsx on lines 6..9

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          unsubscribe(chatroom){
        this.props.unsubscribeFromChatroom(chatroom)
        .then( () => this.props.history.push(`/chatrooms/1`) );
    }
      Severity: Major
      Found in frontend/components/chat/chatroom_header.jsx and 1 other location - About 1 hr to fix
      frontend/components/chat/chatroom_list.jsx on lines 33..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function displayChannelList has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                                  {   this.state.chatrooms.map( chatroom => {
                                { if (chatroom.chatroom_type === 'channel' && chatroom.title.toLowerCase().includes(this.state.inputBox.toLowerCase()) ) {
                                    return (
                                        <Link   key={`chatroom-${chatroom.id}`} 
                                                to={`/chatrooms/${chatroom.id}`}
      Severity: Minor
      Found in frontend/components/chat/chatroom_add.jsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                    <input  type="text"
                                    placeholder="Search Channels"
                                    onChange={this.handleInput('inputBox')}
                                    autoFocus
                                    onKeyDown={ (e) => this.handleEnterKey(e) }
        Severity: Minor
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 55 mins to fix
        frontend/components/chat/chatroom_add.jsx on lines 155..160

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                <input  type="text"
                                placeholder="Find a user"
                                onChange={this.handleInput('inputBox')}
                                autoFocus
                                onKeyDown={ (e) => this.handleEnterKey(e) }
        Severity: Minor
        Found in frontend/components/chat/chatroom_add.jsx and 1 other location - About 55 mins to fix
        frontend/components/chat/chatroom_add.jsx on lines 221..226

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function componentDidUpdate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            componentDidUpdate(previousProps) {
        if (this.props.match.params.chatroomId != previousProps.match.params.chatroomId) {
            this.props.fetchUser(this.props.currentUser.id);
            this.props.fetchMessages(this.props.match.params.chatroomId)
            .then( () => $('#message-window').scrollTop($('#message-window')[0].scrollHeight), 500);
        Severity: Minor
        Found in frontend/components/messages/message_window.jsx - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        export const createChatroom = (chatroom) => (
    $.ajax({
        method: 'POST',
        url: `/api/chatrooms/`,
        data: { chatroom }
        Severity: Major
        Found in frontend/util/chatrooms_api_util.js and 2 other locations - About 40 mins to fix
        frontend/util/chatrooms_api_util.js on lines 37..43
        frontend/util/messages_api_util.js on lines 22..28

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

                let errors = this.props.errors.map( error => 
            <li key={error}> {error} </li> 
            )
        Severity: Major
        Found in frontend/components/messages/message_item_edit.jsx and 3 other locations - About 40 mins to fix
        frontend/components/chat/chatroom_add.jsx on lines 128..130
        frontend/components/session/login_form.jsx on lines 84..86
        frontend/components/session/signup_form.jsx on lines 39..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        export const createMessage = (message) => (
    $.ajax({
        method: 'POST',
        url: `/api/messages/`,
        data: { message }
        Severity: Major
        Found in frontend/util/messages_api_util.js and 2 other locations - About 40 mins to fix
        frontend/util/chatrooms_api_util.js on lines 14..20
        frontend/util/chatrooms_api_util.js on lines 37..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

                let errors = this.props.errors.map( error => 
            <li key={error}> {error} </li> 
            )
        Severity: Major
        Found in frontend/components/session/login_form.jsx and 3 other locations - About 40 mins to fix
        frontend/components/chat/chatroom_add.jsx on lines 128..130
        frontend/components/messages/message_item_edit.jsx on lines 42..44
        frontend/components/session/signup_form.jsx on lines 39..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

                let errors = this.props.errors.map( error => 
            <li key={error}> {error} </li> 
            )
        Severity: Major
        Found in frontend/components/chat/chatroom_add.jsx and 3 other locations - About 40 mins to fix
        frontend/components/messages/message_item_edit.jsx on lines 42..44
        frontend/components/session/login_form.jsx on lines 84..86
        frontend/components/session/signup_form.jsx on lines 39..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        export const createChatroomSubscription = ( chatroom_subscription ) => (
    $.ajax({
        method: 'POST',
        url: `/api/chatroom_subscriptions/`,
        data: { chatroom_subscription }
        Severity: Major
        Found in frontend/util/chatrooms_api_util.js and 2 other locations - About 40 mins to fix
        frontend/util/chatrooms_api_util.js on lines 14..20
        frontend/util/messages_api_util.js on lines 22..28

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

                let errors = this.props.errors.map( error => 
            <li key={error}> {error} </li> 
            )
        Severity: Major
        Found in frontend/components/session/signup_form.jsx and 3 other locations - About 40 mins to fix
        frontend/components/chat/chatroom_add.jsx on lines 128..130
        frontend/components/messages/message_item_edit.jsx on lines 42..44
        frontend/components/session/login_form.jsx on lines 84..86

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            render() {
        let chatroomTitle = "";
        let welcomeMessage = "";
        if ( this.props.currentChatroom ) {
            if (this.props.currentChatroom.chatroom_type == 'channel') {
        Severity: Minor
        Found in frontend/components/messages/message_window.jsx - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language