Sign upLogin

jameshuynh/formnestic

View on GitHub
Star

Showing 11 of 11 total issues

Method formnestic_table_semantic_fields_for has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def formnestic_table_semantic_fields_for(
        record_or_name_or_array, *args, &block
      )
        options = args.dup.extract_options!
        formnestic_add_table_headers_form_attributes
Severity: Minor
Found in lib/formnestic/form_builder/table_form_builder.rb - About 1 hr to fix

    Method formnestic_list_semantic_fields_for has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def formnestic_list_semantic_fields_for(
        record_or_name_or_array,
        *args,
        &block
      )
    Severity: Minor
    Found in lib/formnestic/form_builder/list_form_builder.rb - About 1 hr to fix

      Method formnestic_list_row_inputs has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def formnestic_list_row_inputs(*args, &block)
        html_options =
          formnestic_prepare_html_options_for_wrapper(:list, *args)
        rows_counter =
          template.content_tag(
      Severity: Minor
      Found in lib/formnestic/helpers/inputs_helper.rb - About 1 hr to fix

        Method extend_form_builder has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def extend_form_builder
      Formtastic::FormBuilder.send(
        :alias_method,
        :formtastic_semantic_fields_for,
        :semantic_fields_for
        Severity: Minor
        Found in lib/formnestic/formtastic_extensions.rb - About 1 hr to fix

          Method formnestic_link_to_add_fields_with_content has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def formnestic_link_to_add_fields_with_content(
        record_or_name_or_array, *args, &block
      )
        relationship = object.class.reflections[record_or_name_or_array.to_s]
        if relationship.nil?
          Severity: Minor
          Found in lib/formnestic/form_builder/base_builder.rb - About 1 hr to fix

            Method formnestic_table_row_inputs has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def formnestic_table_row_inputs(*args, &block)
        html_options =
          formnestic_prepare_html_options_for_wrapper(:table, *args)
        template.content_tag(
          :tr, [
            Severity: Minor
            Found in lib/formnestic/helpers/inputs_helper.rb - About 1 hr to fix

              Method formnestic_link_to_add_fields_with_content has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                    def formnestic_link_to_add_fields_with_content(
        record_or_name_or_array, *args, &block
      )
        relationship = object.class.reflections[record_or_name_or_array.to_s]
        if relationship.nil?
              Severity: Minor
              Found in lib/formnestic/form_builder/base_builder.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if (maxNumberOfEntries !== -1 && counter >= maxNumberOfEntries) {
      addRowLinkContainer.addClass("formnestic-hidden");
    } else {
      addRowLinkContainer.removeClass("formnestic-hidden");
    }//end else
              Severity: Major
              Found in app/assets/javascripts/formnestic/formnestic.js and 3 other locations - About 40 mins to fix
              app/assets/javascripts/formnestic/formnestic.js on lines 67..71
              app/assets/javascripts/formnestic/formnestic.js on lines 110..114
              app/assets/javascripts/formnestic/formnestic.js on lines 127..131

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if (maxNumberOfEntries !== -1 && counter >= maxNumberOfEntries) {
      linkDomjQuery.addClass("formnestic-hidden");
    } else {
      linkDomjQuery.removeClass("formnestic-hidden");
    }//end else
              Severity: Major
              Found in app/assets/javascripts/formnestic/formnestic.js and 3 other locations - About 40 mins to fix
              app/assets/javascripts/formnestic/formnestic.js on lines 43..47
              app/assets/javascripts/formnestic/formnestic.js on lines 67..71
              app/assets/javascripts/formnestic/formnestic.js on lines 110..114

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if (maxNumberOfEntries !== -1 && counter >= maxNumberOfEntries) {
      linkDomContainer.addClass("formnestic-hidden");
    } else {
      linkDomContainer.removeClass("formnestic-hidden");
    }//end else
              Severity: Major
              Found in app/assets/javascripts/formnestic/formnestic.js and 3 other locations - About 40 mins to fix
              app/assets/javascripts/formnestic/formnestic.js on lines 43..47
              app/assets/javascripts/formnestic/formnestic.js on lines 67..71
              app/assets/javascripts/formnestic/formnestic.js on lines 127..131

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if (maxNumberOfEntries !== -1 && counter >= maxNumberOfEntries) {
        addRowLink.addClass("formnestic-hidden");
    } else {
      addRowLink.removeClass("formnestic-hidden");
    }//end else
              Severity: Major
              Found in app/assets/javascripts/formnestic/formnestic.js and 3 other locations - About 40 mins to fix
              app/assets/javascripts/formnestic/formnestic.js on lines 43..47
              app/assets/javascripts/formnestic/formnestic.js on lines 110..114
              app/assets/javascripts/formnestic/formnestic.js on lines 127..131

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language