Sign upLogin

jamie-ci/jamie

View on GitHub
Star

Showing 10 of 10 total issues

File jamie.rb has 1047 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'base64'
require 'benchmark'
require 'celluloid'
require 'delegate'
require 'digest'
Severity: Major
Found in lib/jamie.rb - About 2 days to fix

    File cli.rb has 426 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'benchmark'
require 'ostruct'
require 'thor'

require 'jamie'
    Severity: Minor
    Found in lib/jamie/cli.rb - About 6 hrs to fix

      Class Instance has 30 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Instance

    include Celluloid
    include Logging
      Severity: Minor
      Found in lib/jamie.rb - About 3 hrs to fix

        Class Config has 27 methods (exceeds 20 allowed). Consider refactoring.
        Open

          class Config

    attr_writer :yaml_file
    attr_writer :platforms
    attr_writer :suites
        Severity: Minor
        Found in lib/jamie.rb - About 3 hrs to fix

          Method default_yaml has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def default_yaml
      url_base = "https://opscode-vm.s3.amazonaws.com/vagrant/boxes"
      platforms = [
        { :n => 'ubuntu', :vers => %w(12.04 10.04), :rl => "recipe[apt]" },
        { :n => 'centos', :vers => %w(6.3 5.8), :rl => "recipe[yum::epel]" },
          Severity: Minor
          Found in lib/jamie/cli.rb - About 1 hr to fix

            Method add_plugins has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def add_plugins
      prompt_add  = "Add a Driver plugin to your Gemfile? (y/n)>"
      prompt_name = "Enter gem name, `list', or `skip'>"

      if yes?(prompt_add, :green)
            Severity: Minor
            Found in lib/jamie/cli.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method required_config has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def self.required_config(attr, &block)
        @validations = [] if @validations.nil?
        if ! block_given?
          klass = self
          block = lambda do |attr, value|
            Severity: Minor
            Found in lib/jamie.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method pry_prompts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def pry_prompts
      [
        proc { |target_self, nest_level, pry|
          ["[#{pry.input_array.size}] ",
            "jc(#{Pry.view_clip(target_self.class)})",
            Severity: Minor
            Found in lib/jamie/cli.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    proc { |target_self, nest_level, pry|
          ["[#{pry.input_array.size}] ",
            "jc(#{Pry.view_clip(target_self.class)})",
            "#{":#{nest_level}" unless nest_level.zero?}> "
          ].join
            Severity: Minor
            Found in lib/jamie/cli.rb and 1 other location - About 20 mins to fix
            lib/jamie/cli.rb on lines 230..234

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    proc { |target_self, nest_level, pry|
          ["[#{pry.input_array.size}] ",
            "jc(#{Pry.view_clip(target_self.class)})",
            "#{":#{nest_level}" unless nest_level.zero?}* "
          ].join
            Severity: Minor
            Found in lib/jamie/cli.rb and 1 other location - About 20 mins to fix
            lib/jamie/cli.rb on lines 224..228

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language