Sign upLogin

jandjerry/tinyfw

View on GitHub
Star

Showing 13 of 13 total issues

Function processRouting has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    private function processRouting()
    {
        //For nginx or cgi applications
        if (!$this->getVariable('_contr_')) {
            $route = $this->getVariable('_route_');
Severity: Minor
Found in src/jerry/TinyFw/Input.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function debug has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private function debug()
    {
        if (!empty($this->errorCallbackFunction)) {
            $error = array("Error" => $this->error);
            if (!empty($this->sql)) {
Severity: Minor
Found in src/jerry/TinyFw/DB/MySQLPDO.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if (isset($tmp[$i])) {
                            $this->get['_params_'][] = $tmp[$i];
                        }
Severity: Major
Found in src/jerry/TinyFw/Input.php - About 45 mins to fix

    Function filter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function filter($table, $info)
    {
        $driver = $this->getAttribute(\PDO::ATTR_DRIVER_NAME);
        if ($driver == 'sqlite') {
            $sql = "PRAGMA table_info('" . $table . "');";
    Severity: Minor
    Found in src/jerry/TinyFw/DB/MySQLPDO.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused parameters such as '$domain'.
    Open

        public static function trans($string, $domain = 'default')
    Severity: Minor
    Found in src/jerry/TinyFw/Lang.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused private methods such as 'processRequest'.
    Open

        private function processRequest()
    {
        $stdInput = file_get_contents("php://input");
        //TODO Improve this to match with headers
        if($stdInput){
    Severity: Minor
    Found in src/jerry/TinyFw/Input.php by phpmd

    UnusedPrivateMethod

    Since: 0.2

    Unused Private Method detects when a private method is declared but is unused.

    Example

    class Something
{
    private function foo() {} // unused
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

    Avoid unused private methods such as 'processRouting'.
    Open

        private function processRouting()
    {
        //For nginx or cgi applications
        if (!$this->getVariable('_contr_')) {
            $route = $this->getVariable('_route_');
    Severity: Minor
    Found in src/jerry/TinyFw/Input.php by phpmd

    UnusedPrivateMethod

    Since: 0.2

    Unused Private Method detects when a private method is declared but is unused.

    Example

    class Something
{
    private function foo() {} // unused
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

    Rule doesn't have all its properties in alphabetical order.
    Open

    .console {
    Severity: Minor
    Found in web/public/_StyleSheet/main.css by csslint

    Rule doesn't have all its properties in alphabetical order.
    Open

    .message-loading {
    Severity: Minor
    Found in web/public/_StyleSheet/main.css by csslint

    TODO found
    Open

            //TODO Improve this to match with headers
    Severity: Minor
    Found in src/jerry/TinyFw/Input.php by fixme

    TODO found
    Open

                    //TODO
    Severity: Minor
    Found in src/jerry/TinyFw/DB/MySQLPDO.php by fixme

    TODO found
    Open

            //TODO
    Severity: Minor
    Found in src/jerry/TinyFw/Lang.php by fixme

    TODO found
    Open

            //TODO better exception handler
    Severity: Minor
    Found in src/jerry/TinyFw/Controller.php by fixme
    Severity
    Category
    Status
    Source
    Language