Sign upLogin

jardiacaj/finem_imperii

View on GitHub
Star
battle/battle_renderer.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function render_battle_for_view has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

def render_battle_for_view(battle: Battle):
    organizations = {}
    characters = {}
    units = {}
    contubernia = {}
Severity: Minor
Found in battle/battle_renderer.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    for contubernium_in_turn in contubernium.battlecontuberniuminturn_set.all():
                        contubernia[contubernium.id]['in_turn'][contubernium_in_turn.battle_turn.num] = {
                            'x_pos': contubernium_in_turn.x_pos,
                            'z_pos': contubernium_in_turn.z_pos,
                            'ammo_remaining': contubernium_in_turn.ammo_remaining,
Severity: Major
Found in battle/battle_renderer.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status