Sign upLogin

jardiacaj/finem_imperii

View on GitHub
Star
battle/models.py

Summary

Maintainability
B
5 hrs
Test Coverage

File models.py has 333 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from collections import namedtuple, defaultdict

import math

from django.urls import reverse
Severity: Minor
Found in battle/models.py - About 4 hrs to fix

    Function get_order has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_order(self):
        if self.world_unit.owner_character:
            return self.world_unit.default_battle_orders
        else:
            strength_proportion = self.battle_side.get_proportional_strength()
    Severity: Minor
    Found in battle/models.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status