Sign upLogin

jaredallard/shinojs

View on GitHub
Star

Showing 4 of 9 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  const response = runMethod(validator, [T, content, {
    getContext: function() { return getContext(content) },
    stash: function(data) { return setData(content, data) },
    getStash: function() { return getData(content) },
    setContext: function(context) { return setContext(content, context) }
Severity: Major
Found in lib/events.js and 1 other location - About 2 hrs to fix
lib/events.js on lines 149..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    const response = runMethod(validator, [T, content, {
      getContext: function() { return getContext(content) },
      stash: function(data) { return setData(content, data) },
      getStash: function() { return getData(content) },
      setContext: function(context) { return setContext(content, context) }
Severity: Major
Found in lib/events.js and 1 other location - About 2 hrs to fix
lib/events.js on lines 218..223

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function send has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async send(params) {
    debug('dm:create', 'sending DM')

    if(!params.to.identifier) throw new Error(`Expected user id, got '${params.to.identifier}'`)
Severity: Minor
Found in adapters/twitter.js - About 1 hr to fix

    Function addValidator has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const addValidator = (validator, root) => {
  root = root ? `${root}.` : '' // append dot notation

  // Generate a base address if not supplied
  let address          = validator.address || randStr({ length: 10 });
    Severity: Minor
    Found in lib/events.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language