Showing 24 of 24 total issues
Function exports
has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring. Open
module.exports = function(options, keying) {
if (typeof options == 'function') {
keying = options;
options = undefined;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exports
has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring. Open
module.exports = function(url, options) {
options = options || {};
var clientID = options.clientID;
return function oauthIntrospection(data, opts, cb) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exports
has 97 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function(options, keying) {
if (typeof options == 'function') {
keying = options;
options = undefined;
}
Function sat
has 85 lines of code (exceeds 25 allowed). Consider refactoring. Open
return function sat(data, cb) {
// Decode the JWT so the header and payload are available, as they contain
// fields needed to find the corresponding key. Note that at this point, the
// assertion has not actually been verified. It will be verified later, after
// the keying material has been retrieved.
Function exports
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
module.exports = function(options, keying) {
options = options || {};
var issuer = options.issuer
, key = options.key
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exports
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function(options, keying) {
options = options || {};
var issuer = options.issuer
, key = options.key
Function exports
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function(url, options) {
options = options || {};
var clientID = options.clientID;
return function oauthIntrospection(data, opts, cb) {
Function oauthIntrospection
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
return function oauthIntrospection(data, opts, cb) {
if (typeof opts == 'function') {
cb = opts;
opts = undefined;
}
Function sat
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
return function sat(claims, options, cb) {
var payload = {}
, header, token, val;
payload.jti = claims.id;
Function keyed
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
function keyed(err, key) {
if (err) { return cb(err); }
var ok;
try {
Function decode
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Decoder.prototype.decode = function(data, options, cb) {
if (typeof options == 'function') {
cb = options;
options = undefined;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handle
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
request.post(url, { form: body }, function handle(err, res, body) {
if (err) { return cb(err); }
if (res.statusCode != 200) {
// TODO: Parse error response
return cb(new Error('Failed token introspection with status code: ' + res.statusCode));
Function decode
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Decoder.prototype.decode = function(data, options, cb) {
if (typeof options == 'function') {
cb = options;
options = undefined;
}
Identical blocks of code found in 2 locations. Consider refactoring. Open
try {
token = jws.sign({ header: header, payload: payload, secret: key });
} catch (ex) {
return cb(ex);
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 52.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
try {
token = jws.sign({ header: header, payload: payload, secret: key });
} catch (ex) {
return cb(ex);
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 52.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function encode
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Encoder.prototype.encode = function(format, claims, options, cb) {
if (typeof options == 'function') {
cb = options;
options = undefined;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return cb(null, token);
Avoid too many return
statements within this function. Open
return cb(ex);
Avoid too many return
statements within this function. Open
return cb(new NotValidError('Token expired'));
Avoid too many return
statements within this function. Open
return cb(null, claims);