jaredhanson/passport-persona

View on GitHub

Showing 2 of 2 total issues

Function authenticate has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Strategy.prototype.authenticate = function(req) {
  var self = this;
  
  if (!req.body || !req.body[this._assertionField]) {
    return this.fail({ message: 'Missing assertion' }, 400);
Severity: Major
Found in lib/strategy.js - About 2 hrs to fix

    Function authenticate has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    Strategy.prototype.authenticate = function(req) {
      var self = this;
      
      if (!req.body || !req.body[this._assertionField]) {
        return this.fail({ message: 'Missing assertion' }, 400);
    Severity: Minor
    Found in lib/strategy.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language