jaredhanson/passport

View on GitHub

Showing 25 of 25 total issues

Function authenticate has a Cognitive Complexity of 110 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function authenticate(passport, name, options, callback) {
  if (typeof options == 'function') {
    callback = options;
    options = {};
  }
Severity: Minor
Found in lib/middleware/authenticate.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function authenticate has 170 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function authenticate(passport, name, options, callback) {
  if (typeof options == 'function') {
    callback = options;
    options = {};
  }
Severity: Major
Found in lib/middleware/authenticate.js - About 6 hrs to fix

    Function authenticate has 158 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function authenticate(req, res, next) {
        if (http.IncomingMessage.prototype.logIn
            && http.IncomingMessage.prototype.logIn !== IncomingMessageExt.logIn) {
          require('../framework/connect').__monkeypatchNode();
        }
    Severity: Major
    Found in lib/middleware/authenticate.js - About 6 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (options.failureFlash) {
              var flash = options.failureFlash;
              if (typeof flash == 'string') {
                flash = { type: 'error', message: flash };
              }
      Severity: Major
      Found in lib/middleware/authenticate.js and 1 other location - About 5 hrs to fix
      lib/middleware/authenticate.js on lines 225..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (options.successFlash) {
                var flash = options.successFlash;
                if (typeof flash == 'string') {
                  flash = { type: 'success', message: flash };
                }
      Severity: Major
      Found in lib/middleware/authenticate.js and 1 other location - About 5 hrs to fix
      lib/middleware/authenticate.js on lines 121..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (options.successMessage) {
                msg = options.successMessage;
                if (typeof msg == 'boolean') {
                  msg = info.message || info;
                }
      Severity: Major
      Found in lib/middleware/authenticate.js and 1 other location - About 3 hrs to fix
      lib/middleware/authenticate.js on lines 134..143

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if (options.failureMessage) {
              msg = options.failureMessage;
              if (typeof msg == 'boolean') {
                msg = challenge.message || challenge;
              }
      Severity: Major
      Found in lib/middleware/authenticate.js and 1 other location - About 3 hrs to fix
      lib/middleware/authenticate.js on lines 238..247

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function attempt has 93 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          (function attempt(i) {
            var layer = name[i];
            // If no more strategies exist in the chain, authentication has failed.
            if (!layer) { return allFailed(); }
          
      Severity: Major
      Found in lib/middleware/authenticate.js - About 3 hrs to fix

        Function success has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              strategy.success = function(user, info) {
                if (callback) {
                  return callback(null, user, info);
                }
              
        Severity: Major
        Found in lib/middleware/authenticate.js - About 2 hrs to fix

          Function allFailed has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function allFailed() {
                if (callback) {
                  if (!multi) {
                    return callback(null, false, failures[0].challenge, failures[0].status);
                  } else {
          Severity: Major
          Found in lib/middleware/authenticate.js - About 2 hrs to fix

            Function deserializeUser has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

            Authenticator.prototype.deserializeUser = function(fn, req, done) {
              if (typeof fn === 'function') {
                return this._deserializers.push(fn);
              }
              
            Severity: Minor
            Found in lib/authenticator.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function transformAuthInfo has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

            Authenticator.prototype.transformAuthInfo = function(fn, req, done) {
              if (typeof fn === 'function') {
                return this._infoTransformers.push(fn);
              }
              
            Severity: Minor
            Found in lib/authenticator.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function logIn has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            req.logIn = function(user, options, done) {
              if (typeof options == 'function') {
                done = options;
                options = {};
              }
            Severity: Minor
            Found in lib/http/request.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function serializeUser has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            Authenticator.prototype.serializeUser = function(fn, req, done) {
              if (typeof fn === 'function') {
                return this._serializers.push(fn);
              }
              
            Severity: Minor
            Found in lib/authenticator.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                try {
                  var arity = layer.length;
                  if (arity == 3) {
                    layer(req, user, serialized);
                  } else {
            Severity: Major
            Found in lib/authenticator.js and 1 other location - About 1 hr to fix
            lib/authenticator.js on lines 352..361

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                try {
                  var arity = layer.length;
                  if (arity == 3) {
                    layer(req, obj, deserialized);
                  } else {
            Severity: Major
            Found in lib/authenticator.js and 1 other location - About 1 hr to fix
            lib/authenticator.js on lines 289..298

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function transformAuthInfo has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Authenticator.prototype.transformAuthInfo = function(fn, req, done) {
              if (typeof fn === 'function') {
                return this._infoTransformers.push(fn);
              }
              
            Severity: Minor
            Found in lib/authenticator.js - About 1 hr to fix

              Function deserializeUser has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Authenticator.prototype.deserializeUser = function(fn, req, done) {
                if (typeof fn === 'function') {
                  return this._deserializers.push(fn);
                }
                
              Severity: Minor
              Found in lib/authenticator.js - About 1 hr to fix

                Function serializeUser has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Authenticator.prototype.serializeUser = function(fn, req, done) {
                  if (typeof fn === 'function') {
                    return this._serializers.push(fn);
                  }
                  
                Severity: Minor
                Found in lib/authenticator.js - About 1 hr to fix

                  Consider simplifying this complex logical expression.
                  Open

                        if (options.failureFlash) {
                          var flash = options.failureFlash;
                          if (typeof flash == 'string') {
                            flash = { type: 'error', message: flash };
                          }
                  Severity: Major
                  Found in lib/middleware/authenticate.js - About 40 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language