Sign upLogin

jaroslavtyc/doctrineum-integer

View on GitHub
Star

Showing 61 of 61 total issues

IntegerEnumTypeTest has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

class IntegerEnumTypeTest extends AbstractSelfRegisteringTypeTest
{

    /**
     * @throws \Doctrine\DBAL\DBALException
Severity: Minor
Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php - About 3 hrs to fix

    The class IntegerEnumTest has 14 public methods. Consider refactoring IntegerEnumTest to keep number of public methods under 10.
    Open

    class IntegerEnumTest extends TestCase
{
    /**
     * @test
     */
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTest.php by phpmd

    TooManyPublicMethods

    Since: 0.1

    A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

    By default it ignores methods starting with 'get' or 'set'.

    Example

    Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

    The class IntegerEnumTypeTest has 23 public methods. Consider refactoring IntegerEnumTypeTest to keep number of public methods under 10.
    Open

    class IntegerEnumTypeTest extends AbstractSelfRegisteringTypeTest
{

    /**
     * @throws \Doctrine\DBAL\DBALException
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    TooManyPublicMethods

    Since: 0.1

    A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

    By default it ignores methods starting with 'get' or 'set'.

    Example

    Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

    Avoid excessively long variable names like $externalRootReflection. Keep variable name length under 20.
    Open

            $externalRootReflection = new \ReflectionClass(ScalarEnum::class);
    Severity: Minor
    Found in Doctrineum/Tests/Integer/DoctrineumIntegerExceptionsHierarchyTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $matchingValueToConvert. Keep variable name length under 20.
    Open

            $matchingValueToConvert = 123456789;
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $nonMatchingValueToConvert. Keep variable name length under 20.
    Open

            $nonMatchingValueToConvert = 99999999;
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Missing class import via use statement (line '233', column '49').
    Open

            $integerEnumType->convertToPHPValue(new \stdClass(), $this->getAbstractPlatform());
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '33', column '39').
    Open

            $externalRootReflection = new \ReflectionClass(ScalarEnum::class);
    Severity: Minor
    Found in Doctrineum/Tests/Integer/DoctrineumIntegerExceptionsHierarchyTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'tearDown'.
    Open

            $integerEnumType = Type::getType($this->getExpectedTypeName());
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Mockery' in method 'subtype_returns_proper_enum'.
    Open

            $abstractPlatform = \Mockery::mock(AbstractPlatform::class);
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Mockery' in method 'getPlatform'.
    Open

            return \Mockery::mock(AbstractPlatform::class);
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Granam\Integer\Tools\ToInteger' in method 'toInteger'.
    Open

                return ToInteger::toInteger($value, true /* strict */);
    Severity: Minor
    Found in Doctrineum/Integer/IntegerEnumType.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused parameters such as '$fieldDeclaration'.
    Open

            array $fieldDeclaration,
    Severity: Minor
    Found in Doctrineum/Integer/IntegerEnumType.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$platform'.
    Open

            AbstractPlatform $platform
    Severity: Minor
    Found in Doctrineum/Integer/IntegerEnumType.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$platform'.
    Open

            AbstractPlatform $platform
    Severity: Minor
    Found in Doctrineum/Integer/IntegerEnumType.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'different_types_with_same_subtype_regexp_distinguish_them'.
    Open

            $integerEnumType = Type::getType($this->getExpectedTypeName());
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Mockery' in method 'getAbstractPlatform'.
    Open

            return \Mockery::mock(AbstractPlatform::class);
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Mockery' in method 'default_enum_is_given_if_subtype_does_not_match'.
    Open

            $abstractPlatform = \Mockery::mock(AbstractPlatform::class);
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'setUp'.
    Open

            if (!Type::hasType($this->getExpectedTypeName())) {
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'setUp'.
    Open

                Type::addType($this->getExpectedTypeName(), $this->getTypeClass());
    Severity: Minor
    Found in Doctrineum/Tests/Integer/IntegerEnumTypeTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Severity
    Category
    Status
    Source
    Language