Sign upLogin

jaroslavtyc/drd-plus-calculations

View on GitHub
Star

Showing 45 of 45 total issues

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_get_ceiled_third'.
Open

        self::assertSame(1, SumAndRound::ceiledThird($number));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_get_floored_third'.
Open

        self::assertSame(33, SumAndRound::flooredThird($number));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Granam\Float\Tools\ToFloat' in method 'flooredThird'.
Open

        return self::floor(ToFloat::toFloat($number) / 3);
Severity: Minor
Found in Calculations/SumAndRound.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_get_round_average_of_two_numbers'.
Open

        self::assertSame(1, SumAndRound::average($firstNumber, $secondNumber));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_get_third'.
Open

        self::assertSame(1, SumAndRound::third($number));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_get_ceiled_third'.
Open

        self::assertSame(33, SumAndRound::ceiledThird($number));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_get_floored_third'.
Open

        self::assertSame(1, SumAndRound::flooredThird($number));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_ceil_a_number'.
Open

        self::assertSame(6, SumAndRound::ceil($almostHigherInteger));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_round_a_number'.
Open

        self::assertSame(4, SumAndRound::round($shouldBeLower));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_get_third'.
Open

        self::assertSame(0, SumAndRound::third($number));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Granam\Float\Tools\ToFloat' in method 'average'.
Open

        return self::round((ToFloat::toFloat($firstNumber) + ToFloat::toFloat($secondNumber)) / 2);
Severity: Minor
Found in Calculations/SumAndRound.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_floor_a_number'.
Open

        self::assertSame(5, SumAndRound::floor($almostHigherInteger));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'I_can_get_round_half'.
Open

        self::assertSame(3, SumAndRound::half($number));
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Granam\Float\Tools\ToFloat' in method 'floor'.
Open

        return (int)floor(ToFloat::toFloat($number));
Severity: Minor
Found in Calculations/SumAndRound.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Granam\Float\Tools\ToFloat' in method 'ceiledThird'.
Open

        return self::ceil(ToFloat::toFloat($number) / 3);
Severity: Minor
Found in Calculations/SumAndRound.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method I_can_get_third is not named in camelCase.
Open

    public function I_can_get_third(): void
    {
        $number = 7.5;
        self::assertSame(3, SumAndRound::third($number));
        $number = 2.9999;
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_round_half is not named in camelCase.
Open

    public function I_can_get_round_half(): void
    {
        $number = 5;
        self::assertSame(3, SumAndRound::half($number));
        $number = 4.99;
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_floored_half is not named in camelCase.
Open

    public function I_can_get_floored_half(): void
    {
        $number = 5;
        self::assertSame(2, SumAndRound::flooredHalf($number));
        $number = 4.0001;
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_ceiled_half is not named in camelCase.
Open

    public function I_can_get_ceiled_half(): void
    {
        $number = 5;
        self::assertSame(3, SumAndRound::ceiledHalf($number));
        $number = 4.0001;
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_floor_a_number is not named in camelCase.
Open

    public function I_can_floor_a_number(): void
    {
        $almostHigherInteger = 5.999999;
        self::assertSame(5, SumAndRound::floor($almostHigherInteger));
    }
Severity: Minor
Found in tests/Calculations/SumAndRoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language