jaroslavtyc/drd-plus-codes

View on GitHub
Codes/Transport/RidingAnimalCode.php

Summary

Maintainability
F
5 days
Test Coverage

Method fetchTranslations has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function fetchTranslations(): array
    {
        return [
            'en' => [
                self::HORSE => [self::$ONE => 'horse', self::$FEW => 'horses', self::$MANY => 'horses'],
Severity: Minor
Found in Codes/Transport/RidingAnimalCode.php - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                'en' => [
                    self::HORSE => [self::$ONE => 'horse', self::$FEW => 'horses', self::$MANY => 'horses'],
                    self::DRAFT_HORSE => [self::$ONE => 'draft horse', self::$FEW => 'draft horses', self::$MANY => 'draft horses'],
                    self::RIDING_HORSE => [self::$ONE => 'riding horse', self::$FEW => 'riding horses', self::$MANY => 'riding horses'],
                    self::WAR_HORSE => [self::$ONE => 'war horse', self::$FEW => 'war horses', self::$MANY => 'war horses'],
    Severity: Major
    Found in Codes/Transport/RidingAnimalCode.php and 1 other location - About 2 days to fix
    Codes/Transport/RidingAnimalCode.php on lines 86..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 501.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                'cs' => [
                    self::HORSE => [self::$ONE => 'kůň', self::$FEW => 'koně', self::$MANY => 'koní'],
                    self::DRAFT_HORSE => [self::$ONE => 'tažný kůň', self::$FEW => 'tažné koně', self::$MANY => 'tažných koní'],
                    self::RIDING_HORSE => [self::$ONE => 'jezdecký kůň', self::$FEW => 'jezdečtí koně', self::$MANY => 'jezdeckých koní'],
                    self::WAR_HORSE => [self::$ONE => 'válečný kůň', self::$FEW => 'válečné koně', self::$MANY => 'válečných koní'],
    Severity: Major
    Found in Codes/Transport/RidingAnimalCode.php and 1 other location - About 2 days to fix
    Codes/Transport/RidingAnimalCode.php on lines 69..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 501.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid excessively long variable names like $newRidingAnimalCodeValue. Keep variable name length under 20.
    Open

        public static function addNewRidingAnimalCode(string $newRidingAnimalCodeValue, array $translations): bool
    Severity: Minor
    Found in Codes/Transport/RidingAnimalCode.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status